From 095f79cde5fb0941b2b04ff83273755431371050 Mon Sep 17 00:00:00 2001
From: Yehuda Sadeh <yehuda@hq.newdream.net>
Date: Tue, 26 May 2009 11:40:50 -0700
Subject: [PATCH] class: don't add a class when no valid binary is supplied

---
 src/mon/ClassMonitor.cc | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/src/mon/ClassMonitor.cc b/src/mon/ClassMonitor.cc
index 5e12c246ed648..2e23d24398906 100644
--- a/src/mon/ClassMonitor.cc
+++ b/src/mon/ClassMonitor.cc
@@ -315,24 +315,29 @@ bool ClassMonitor::prepare_command(MMonCommand *m)
       string name = m->cmd[2];
       string ver = m->cmd[3];
       string arch = m->cmd[4];
+
+      ClassImpl impl;
+      impl.binary = m->get_data();
+      if (impl.binary.length() <= 0) {
+         ss << "invalid binary data";
+         rs = -ENOENT;
+         goto done;
+      }
+      impl.stamp = g_clock.now();
+
       ClassVersionMap& map = list.library_map[name];
       ClassVersion cv(ver, arch);
       ClassInfo& info = map.m[cv];
-      ClassImpl impl;
-      impl.binary = m->get_data();
       dout(0) << "payload.length=" << m->get_data().length() << dendl;
-      impl.stamp = g_clock.now();
       info.name = name;
       info.version = cv;
-      /* store_impl(info, impl); */
-      dout(0) << "stored class " << name << " v" << info.version << dendl;
       ClassLibraryIncremental inc;
+      dout(0) << "storing class " << name << " v" << info.version << dendl;
       ::encode(impl, inc.impl);
       ::encode(info, inc.info);
       inc.op = INC_ADD;
       pending_list.add(info);
       pending_class.insert(pair<utime_t,ClassLibraryIncremental>(impl.stamp, inc));
-
       ss << "updated";
       getline(ss, rs);
       paxos->wait_for_commit(new Monitor::C_Command(mon, m, 0, rs));
-- 
2.39.5