From 0d924258b363c1491b1fffcafdd038b75b27ccb1 Mon Sep 17 00:00:00 2001 From: Yingxin Cheng Date: Thu, 1 Aug 2024 16:46:39 +0800 Subject: [PATCH] crimson/os/seastore/cache: cleanup remove_from_dirty() Signed-off-by: Yingxin Cheng --- src/crimson/os/seastore/cache.cc | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/crimson/os/seastore/cache.cc b/src/crimson/os/seastore/cache.cc index fcc3507f9d949..6963e3d351df9 100644 --- a/src/crimson/os/seastore/cache.cc +++ b/src/crimson/os/seastore/cache.cc @@ -766,14 +766,11 @@ void Cache::add_to_dirty(CachedExtentRef ref) void Cache::remove_from_dirty(CachedExtentRef ref) { - if (ref->is_dirty()) { - ceph_assert(ref->primary_ref_list_hook.is_linked()); - stats.dirty_bytes -= ref->get_length(); - dirty.erase(dirty.s_iterator_to(*ref)); - intrusive_ptr_release(&*ref); - } else { - ceph_assert(!ref->primary_ref_list_hook.is_linked()); - } + assert(ref->is_dirty()); + ceph_assert(ref->primary_ref_list_hook.is_linked()); + stats.dirty_bytes -= ref->get_length(); + dirty.erase(dirty.s_iterator_to(*ref)); + intrusive_ptr_release(&*ref); } void Cache::remove_extent(CachedExtentRef ref) -- 2.39.5