From 0edc573fcacb382e0de1b98446af6a214e291d26 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Tue, 27 Jul 2021 11:42:59 +0800 Subject: [PATCH] include/denc: always initialize local variable MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit this change silences following false positive warning: In file included from ../src/include/encoding.h:41, from ../src/kv/KeyValueDB.h:12, from ../src/os/bluestore/bluestore_common.h:20, from ../src/os/bluestore/BlueFS.cc:5: ../src/include/denc.h: In function ‘std::enable_if_t<(is_same_v || is_same_v)> _denc_friend(T&, P&) [with T = bluefs_extent_t; P = ceph::buffer::v15_2_0::p$ ../src/include/denc.h:639:11: warning: ‘shift’ may be used uninitialized in this function [-Wmaybe-uninitialized] 639 | shift += 7; | ~~~~~~^~~~ ../src/include/denc.h:613:7: note: ‘shift’ was declared here 613 | int shift; | ^~~~~ Signed-off-by: Kefu Chai --- src/include/denc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/include/denc.h b/src/include/denc.h index 10fa8d0c871..71db1003ace 100644 --- a/src/include/denc.h +++ b/src/include/denc.h @@ -610,7 +610,7 @@ template inline std::enable_if_t> denc_lba(uint64_t& v, It& p) { uint32_t word = *(ceph_le32*)p.get_pos_add(sizeof(uint32_t)); - int shift; + int shift = 0; switch (word & 7) { case 0: case 2: -- 2.39.5