From 0f15976139efcbf5ef039a05f9e9a8f6b3587bda Mon Sep 17 00:00:00 2001
From: nsedrickm <nsedrick101@gmail.com>
Date: Tue, 5 Jul 2022 16:53:21 +0100
Subject: [PATCH] mgr/dashboard: Improve level A accessibility for buttons

Add titles and aria-labels for icon only buttons so that they can be detected by screen readers

Fixes: https://tracker.ceph.com/issues/56018
Signed-off-by: nsedrickm <nsedrick101@gmail.com>
(cherry picked from commit 5458e1a020fb5d0fe3ae77155c79cd53783a1c8a)
---
 .../ceph/block/mirroring/overview/overview.component.html   | 3 ++-
 .../frontend/src/app/ceph/cluster/logs/logs.component.html  | 6 ++++--
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/overview/overview.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/overview/overview.component.html
index 9cdfab939cc2a..2d2f13c6b9e95 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/overview/overview.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/mirroring/overview/overview.component.html
@@ -20,7 +20,8 @@
           <div class="input-group-append">
             <button class="btn btn-light"
                     id="editSiteName"
-                    (click)="updateSiteName()">
+                    (click)="updateSiteName()"
+                    [attr.title]="editing ? 'Save' : 'Edit'">
               <i [ngClass]="icons.edit"
                  *ngIf="!editing"></i>
               <i [ngClass]="icons.check"
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.html
index d5c73eb73904a..5c84673698a00 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/logs/logs.component.html
@@ -120,7 +120,8 @@
         <div class="input-group-append">
           <button type="button"
                   class="btn btn-light"
-                  (click)="clearSearchKey()">
+                  (click)="clearSearchKey()"
+                  title="Clear">
             <i class="icon-prepend {{ icons.destroy }}"></i>
           </button>
         </div>
@@ -143,7 +144,8 @@
         <span class="input-group-append">
           <button type="button"
                   class="btn btn-light"
-                  (click)="clearDate()">
+                  (click)="clearDate()"
+                  title="Clear">
             <i class="icon-prepend {{ icons.destroy }}"></i>
           </button>
         </span>
-- 
2.39.5