From 0f2ffa770d82227a7c6341266c9ebf9342c9b1be Mon Sep 17 00:00:00 2001 From: Max Kellermann Date: Tue, 8 Oct 2024 10:57:36 +0200 Subject: [PATCH] msg/async/ProtocolV[12]: use `auto` Signed-off-by: Max Kellermann (cherry picked from commit 988705a49b58dfd78a8cc7c1a865343f925a8c53) --- src/msg/async/ProtocolV1.cc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/msg/async/ProtocolV1.cc b/src/msg/async/ProtocolV1.cc index 19899831318..f938930d573 100644 --- a/src/msg/async/ProtocolV1.cc +++ b/src/msg/async/ProtocolV1.cc @@ -818,7 +818,7 @@ CtPtr ProtocolV1::read_message_data_prepare() { #if 0 // rx_buffers is broken by design... see // http://tracker.ceph.com/issues/22480 - map >::iterator p = + const auto p = connection->rx_buffers.find(current_header.tid); if (p != connection->rx_buffers.end()) { ldout(cct, 10) << __func__ << " seleting rx buffer v " << p->second.second @@ -1203,7 +1203,7 @@ void ProtocolV1::requeue_sent() { return; } - list &rq = out_q[CEPH_MSG_PRIO_HIGHEST]; + auto &rq = out_q[CEPH_MSG_PRIO_HIGHEST]; out_seq -= sent.size(); while (!sent.empty()) { Message *m = sent.back(); @@ -1221,7 +1221,7 @@ uint64_t ProtocolV1::discard_requeued_up_to(uint64_t out_seq, uint64_t seq) { if (out_q.count(CEPH_MSG_PRIO_HIGHEST) == 0) { return seq; } - list &rq = out_q[CEPH_MSG_PRIO_HIGHEST]; + auto &rq = out_q[CEPH_MSG_PRIO_HIGHEST]; uint64_t count = out_seq; while (!rq.empty()) { Message* const m = rq.front().m; @@ -1325,10 +1325,9 @@ void ProtocolV1::reset_recv_state() ProtocolV1::out_q_entry_t ProtocolV1::_get_next_outgoing() { out_q_entry_t out_entry; if (!out_q.empty()) { - map>::reverse_iterator it = - out_q.rbegin(); + const auto it = out_q.rbegin(); ceph_assert(!it->second.empty()); - list::iterator p = it->second.begin(); + const auto p = it->second.begin(); out_entry = *p; it->second.erase(p); if (it->second.empty()) out_q.erase(it->first); -- 2.39.5