From 0f8a61a3ae08cc3b3f2b91968764eeecb565aab6 Mon Sep 17 00:00:00 2001 From: Dimitri Savineau Date: Wed, 10 Jun 2020 10:32:53 -0400 Subject: [PATCH] debian/uca: remove the handler notification The "update apt cache" in the ceph-handler role was never called and the handler trigger after adding the uca repository doesn't exist at all. Instead of using a handler for that we can just set the update_cache parameter to true like the other apt_repository tasks. Signed-off-by: Dimitri Savineau --- roles/ceph-common/tasks/installs/debian_uca_repository.yml | 3 +-- roles/ceph-handler/handlers/main.yml | 7 ------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/roles/ceph-common/tasks/installs/debian_uca_repository.yml b/roles/ceph-common/tasks/installs/debian_uca_repository.yml index d0267f938..7861cfd2d 100644 --- a/roles/ceph-common/tasks/installs/debian_uca_repository.yml +++ b/roles/ceph-common/tasks/installs/debian_uca_repository.yml @@ -9,5 +9,4 @@ apt_repository: repo: "deb {{ ceph_stable_repo_uca }} {{ ceph_stable_release_uca }} main" state: present - update_cache: no - notify: update apt cache if a repo was added + update_cache: yes diff --git a/roles/ceph-handler/handlers/main.yml b/roles/ceph-handler/handlers/main.yml index 4f6b6334c..42d4aa5ff 100644 --- a/roles/ceph-handler/handlers/main.yml +++ b/roles/ceph-handler/handlers/main.yml @@ -4,13 +4,6 @@ - not rolling_update | bool - not docker2podman | default(False) | bool block: - - name: update apt cache - apt: - update-cache: yes - when: ansible_os_family == 'Debian' - register: result - until: result is succeeded - - name: make tempdir for scripts tempfile: state: directory -- 2.39.5