From 10186fe79572b8d87b16fd7c7bd716f7d077ec64 Mon Sep 17 00:00:00 2001 From: Sam Lang Date: Tue, 25 Sep 2012 09:13:26 -0700 Subject: [PATCH] client: Fixes coverity defect 716891 Fix for coverity defect 716891 [DEADCODE] in Client::encode_dentry_release where the released var is initialized to 0, but never set, so the pre-emptive release of the dentry capability (if requested by the drop flag) never happens. Signed-off-by: Sam Lang --- src/client/Client.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/client/Client.cc b/src/client/Client.cc index 694ed0a8cff0f..80cbee8a05fad 100644 --- a/src/client/Client.cc +++ b/src/client/Client.cc @@ -1165,8 +1165,8 @@ void Client::encode_dentry_release(Dentry *dn, MetaRequest *req, << dn << ")" << dendl; int released = 0; if (dn->dir) - encode_inode_release(dn->dir->parent_inode, req, - mds, drop, unless, 1); + released = encode_inode_release(dn->dir->parent_inode, req, + mds, drop, unless, 1); if (released && dn->lease_mds == mds) { ldout(cct, 25) << "preemptively releasing dn to mds" << dendl; MClientRequest::Release& rel = req->cap_releases.back(); -- 2.39.5