From 12c5657cfabafe122d93cd5c03d6e92b581e2e5d Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Wed, 25 May 2016 22:57:36 -0700 Subject: [PATCH] reflink: avoid reflink on swap files Since none of the current filesystems support reflinked swap files, make sure that we prohibit reflinking of swapfiles and swapon of reflinked files. Signed-off-by: Darrick J. Wong Cc: Christoph Hellwig Reviewed-by: Christoph Hellwig Signed-off-by: Eryu Guan --- tests/generic/356 | 74 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/356.out | 6 ++++ tests/generic/357 | 73 ++++++++++++++++++++++++++++++++++++++++++ tests/generic/357.out | 5 +++ tests/generic/group | 2 ++ 5 files changed, 160 insertions(+) create mode 100755 tests/generic/356 create mode 100644 tests/generic/356.out create mode 100755 tests/generic/357 create mode 100644 tests/generic/357.out diff --git a/tests/generic/356 b/tests/generic/356 new file mode 100755 index 00000000..6bb90c0e --- /dev/null +++ b/tests/generic/356 @@ -0,0 +1,74 @@ +#! /bin/bash +# FS QA Test No. 356 +# +# Check that we can't reflink a swapfile. +# +#----------------------------------------------------------------------- +# Copyright (c) 2016 Oracle, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 7 15 + +_cleanup() +{ + cd / + rm -rf $tmp.* + wait +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/reflink + +# real QA test starts here +_supported_os Linux +_require_scratch_reflink +_require_cp_reflink + +echo "Format and mount" +_scratch_mkfs > $seqres.full 2>&1 +_scratch_mount >> $seqres.full 2>&1 + +testdir=$SCRATCH_MNT/test-$seq +mkdir $testdir + +blocks=160 +blksz=65536 + +echo "Initialize file" +echo >> $seqres.full +_pwrite_byte 0x61 0 $((blocks * blksz)) $testdir/file1 >> $seqres.full +mkswap -U 27376b42-ff65-42ca-919f-6c9b62292a5c $testdir/file1 >> $seqres.full +swapon $testdir/file1 + +echo "Try to reflink" +_cp_reflink $testdir/file1 $testdir/file2 2>&1 | _filter_scratch + +echo "Tear it down" +swapoff $testdir/file1 + +# success, all done +status=0 +exit diff --git a/tests/generic/356.out b/tests/generic/356.out new file mode 100644 index 00000000..dff4dbe9 --- /dev/null +++ b/tests/generic/356.out @@ -0,0 +1,6 @@ +QA output created by 356 +Format and mount +Initialize file +Try to reflink +cp: failed to clone 'SCRATCH_MNT/test-356/file2' from 'SCRATCH_MNT/test-356/file1': Text file busy +Tear it down diff --git a/tests/generic/357 b/tests/generic/357 new file mode 100755 index 00000000..439b3141 --- /dev/null +++ b/tests/generic/357 @@ -0,0 +1,73 @@ +#! /bin/bash +# FS QA Test No. 357 +# +# Check that we can't swapon a reflinked file. +# +#----------------------------------------------------------------------- +# Copyright (c) 2016 Oracle, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 7 15 + +_cleanup() +{ + cd / + rm -rf $tmp.* + wait +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/reflink + +# real QA test starts here +_supported_os Linux +_require_scratch_reflink +_require_cp_reflink + +echo "Format and mount" +_scratch_mkfs > $seqres.full 2>&1 +_scratch_mount >> $seqres.full 2>&1 + +testdir=$SCRATCH_MNT/test-$seq +mkdir $testdir + +blocks=160 +blksz=65536 + +echo "Initialize file" +echo >> $seqres.full +_pwrite_byte 0x61 0 $((blocks * blksz)) $testdir/file1 >> $seqres.full +mkswap -U 27376b42-ff65-42ca-919f-6c9b62292a5c $testdir/file1 >> $seqres.full +_cp_reflink $testdir/file1 $testdir/file2 2>&1 | _filter_scratch + +echo "Try to swapon" +swapon $testdir/file1 2>&1 | _filter_scratch + +swapoff $testdir/file1 >> $seqres.full 2>&1 + +# success, all done +status=0 +exit diff --git a/tests/generic/357.out b/tests/generic/357.out new file mode 100644 index 00000000..d1f8d731 --- /dev/null +++ b/tests/generic/357.out @@ -0,0 +1,5 @@ +QA output created by 357 +Format and mount +Initialize file +Try to swapon +swapon: SCRATCH_MNT/test-357/file1: swapon failed: Invalid argument diff --git a/tests/generic/group b/tests/generic/group index 897810f5..0ccc516f 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -358,3 +358,5 @@ 353 auto quick clone 354 auto 355 auto quick +356 auto quick clone +357 auto quick clone -- 2.39.5