From 13b8c92a290ea078af26638fbd23bdb2b8c27bdf Mon Sep 17 00:00:00 2001 From: Danny Al-Gaaf Date: Fri, 19 Sep 2014 12:06:49 +0200 Subject: [PATCH] os/GenericObjectMap.cc: pass big parameter by reference CID 1188142 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE) pass_by_value: Passing parameter header of type GenericObjectMap::_Header (size 176 bytes) by value. Signed-off-by: Danny Al-Gaaf --- src/os/GenericObjectMap.cc | 2 +- src/os/GenericObjectMap.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/os/GenericObjectMap.cc b/src/os/GenericObjectMap.cc index 00387ad666d6d..f6ba11eaf1466 100644 --- a/src/os/GenericObjectMap.cc +++ b/src/os/GenericObjectMap.cc @@ -1025,7 +1025,7 @@ void GenericObjectMap::remove_header(const coll_t &cid, } void GenericObjectMap::set_header(const coll_t &cid, const ghobject_t &oid, - _Header header, KeyValueDB::Transaction t) + _Header &header, KeyValueDB::Transaction t) { dout(20) << __func__ << " setting " << header.seq << " cid " << cid << " oid " << oid << " parent seq " diff --git a/src/os/GenericObjectMap.h b/src/os/GenericObjectMap.h index 4a0c99c94b911..b254795207398 100644 --- a/src/os/GenericObjectMap.h +++ b/src/os/GenericObjectMap.h @@ -220,7 +220,7 @@ class GenericObjectMap { KeyValueDB::Transaction t); /// Set leaf node for c and oid to the value of header - void set_header(const coll_t &cid, const ghobject_t &oid, _Header header, + void set_header(const coll_t &cid, const ghobject_t &oid, _Header &header, KeyValueDB::Transaction t); // Move all modify member function to "protect", in order to indicate these -- 2.39.5