From 14c00baa2071b52facb0c704616d8c76fe720026 Mon Sep 17 00:00:00 2001 From: Somnath Roy Date: Sat, 10 Sep 2016 16:28:32 -0400 Subject: [PATCH] Logging proper message during read error from disk Signed-off-by: Somnath Roy --- src/os/bluestore/KernelDevice.cc | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/os/bluestore/KernelDevice.cc b/src/os/bluestore/KernelDevice.cc index 2f3811ed58f..7c6a6eac186 100644 --- a/src/os/bluestore/KernelDevice.cc +++ b/src/os/bluestore/KernelDevice.cc @@ -509,6 +509,8 @@ int KernelDevice::direct_read_unaligned(uint64_t off, uint64_t len, char *buf) r = ::pread(fd_direct, p.c_str(), aligned_len, aligned_off); if (r < 0) { r = -errno; + derr << __func__ << " 0x" << std::hex << off << "~" << len << std::dec + << " error: " << cpp_strerror(r) << dendl; goto out; } assert((uint64_t)r == aligned_len); @@ -548,6 +550,8 @@ int KernelDevice::read_random(uint64_t off, uint64_t len, char *buf, r = ::pread(fd_buffered, t, left, off); if (r < 0) { r = -errno; + derr << __func__ << " 0x" << std::hex << off << "~" << left + << std::dec << " error: " << cpp_strerror(r) << dendl; goto out; } off += r; @@ -559,6 +563,9 @@ int KernelDevice::read_random(uint64_t off, uint64_t len, char *buf, r = ::pread(fd_direct, buf, len, off); if (r < 0) { r = -errno; + derr << __func__ << " direct_aligned_read" << " 0x" << std::hex + << off << "~" << left << std::dec << " error: " << cpp_strerror(r) + << dendl; goto out; } assert((uint64_t)r == len); -- 2.39.5