From 151bf0eef59acae2d1fcf3f0feb8b6aa963dc2f6 Mon Sep 17 00:00:00 2001 From: Samuel Just Date: Tue, 3 Jul 2012 11:23:16 -0700 Subject: [PATCH] ReplicatedPG: remove faulty scrub assert in sub_op_modify_applied This assert assumed that all ops submitted before MOSDRepScrub was submitted were processed by the time that MOSDRepScrub was processed. In fact, MOSDRepScrub's scrub_to may refer to a last_update yet to be seen by the replica. Bug #2693 Signed-off-by: Samuel Just --- src/osd/ReplicatedPG.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/osd/ReplicatedPG.cc b/src/osd/ReplicatedPG.cc index a2a0efcdce98e..933bdb5992819 100644 --- a/src/osd/ReplicatedPG.cc +++ b/src/osd/ReplicatedPG.cc @@ -4286,7 +4286,6 @@ void ReplicatedPG::sub_op_modify_applied(RepModify *rm) last_update_applied = m->version; if (finalizing_scrub) { assert(active_rep_scrub); - assert(info.last_update <= active_rep_scrub->scrub_to); if (last_update_applied == active_rep_scrub->scrub_to) { osd->rep_scrub_wq.queue(active_rep_scrub); active_rep_scrub = 0; -- 2.39.5