From 152d655fbf291d5e657513e2b2fa5ac99f34b665 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Thu, 10 Dec 2020 17:06:00 +0800 Subject: [PATCH] mon/Monitor: remove unused variable and add error handling Signed-off-by: Kefu Chai --- src/mon/Monitor.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mon/Monitor.cc b/src/mon/Monitor.cc index d28e21a746f7..c2198638de24 100644 --- a/src/mon/Monitor.cc +++ b/src/mon/Monitor.cc @@ -5378,11 +5378,13 @@ void Monitor::get_all_versions(std::map > &versions) void Monitor::get_versions(std::map > &versions) { - int i = 0; for (auto& [rank, metadata] : mon_metadata) { auto q = metadata.find("ceph_version_short"); + if (q == metadata.end()) { + // not likely + continue; + } versions[q->second].push_back(string("mon.") + monmap->get_name(rank)); - i = i + 1; } } -- 2.47.3