From 160b63c616dd8930d39c541b470a2c993a40337f Mon Sep 17 00:00:00 2001 From: Volker Theile Date: Wed, 9 Sep 2020 18:08:17 +0200 Subject: [PATCH] cephadm: Remove assignment to member variable in ServiceSpecs Remove unnecessary assignment to member variable 'preview_only', this is done in the constructor of the derived ServiceSpec class. Fixes: https://tracker.ceph.com/issues/47384 Signed-off-by: Volker Theile (cherry picked from commit 6443ac5efa9816da580fe8546942af0cdf4ed271) --- src/python-common/ceph/deployment/service_spec.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/python-common/ceph/deployment/service_spec.py b/src/python-common/ceph/deployment/service_spec.py index 93c7611d4bce3..3dadb51dc2ddf 100644 --- a/src/python-common/ceph/deployment/service_spec.py +++ b/src/python-common/ceph/deployment/service_spec.py @@ -590,8 +590,6 @@ class NFSServiceSpec(ServiceSpec): #: RADOS namespace where NFS client recovery data is stored in the pool. self.namespace = namespace - self.preview_only = preview_only - def validate(self): super(NFSServiceSpec, self).validate() @@ -661,7 +659,6 @@ class RGWSpec(ServiceSpec): self.rgw_frontend_ssl_certificate = rgw_frontend_ssl_certificate self.rgw_frontend_ssl_key = rgw_frontend_ssl_key self.ssl = ssl - self.preview_only = preview_only def get_port(self): if self.rgw_frontend_port: @@ -725,7 +722,6 @@ class IscsiServiceSpec(ServiceSpec): self.api_secure = api_secure self.ssl_cert = ssl_cert self.ssl_key = ssl_key - self.preview_only = preview_only if not self.api_secure and self.ssl_cert and self.ssl_key: self.api_secure = True -- 2.39.5