From 16b8ac9f19ca91240113e171983f92aae403a4ef Mon Sep 17 00:00:00 2001
From: Sage Weil <sage@newdream.net>
Date: Wed, 26 Mar 2008 11:11:51 -0700
Subject: [PATCH] todos

---
 src/TODO             |  6 ++----
 src/client/Client.cc | 15 ---------------
 2 files changed, 2 insertions(+), 19 deletions(-)

diff --git a/src/TODO b/src/TODO
index 6ebf69672163e..d2214602ba98f 100644
--- a/src/TODO
+++ b/src/TODO
@@ -5,14 +5,12 @@ code cleanup
 - addr=?
 
 client leases
-- clean up readdir vs stat leases
-  - esp on client.. keep mask/ttl and onetime_mask/onetime_ttl?
-  - or just short leases?
 - lease length heuristics
-  - per-object leease durations in client_reply?
+  - mds lock last_change stamp?
 - client: preemptively release lease on dentry we are unlinking, renaming from/to, etc.
   - or inode fields we are chmodding, etc.
 - lease renewals (to avoid blocking client ops?)
+- IFILE vs caps...
 
 userspace client
 - clean up ll_ interface, now that we have leases!
diff --git a/src/client/Client.cc b/src/client/Client.cc
index d8ec3015d0a3e..fd2b5cbe73728 100644
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -2047,10 +2047,6 @@ int Client::_do_lstat(filepath &fpath, int mask, Inode **in)
   
   if (dn && dn->inode && (havemask & mask) == mask) {
     dout(10) << "lstat cache hit w/ sufficient mask, valid until " << dn->inode->ttl << dendl;
-    
-    //if (g_conf.client_cache_stat_ttl == 0)
-    //dn->inode->ttl = utime_t();           // only one stat allowed after each readdir
-
     *in = dn->inode;
   } else {  
     req = new MClientRequest(CEPH_MDS_OP_LSTAT, messenger->get_myinst());
@@ -2089,17 +2085,6 @@ int Client::fill_stat(Inode *in, struct stat *st)
   return in->mask;
 }
 
-  /*
-  S_REQUIREBLKSIZE(st->st_litemask);
-  if (inode.mask & INODE_MASK_BASE) S_REQUIRECTIME(st->st_litemask);
-  if (inode.mask & INODE_MASK_SIZE) {
-    S_REQUIRESIZE(st->st_litemask);
-    S_REQUIREBLOCKS(st->st_litemask);
-  }
-  if (inode.mask & INODE_MASK_MTIME) S_REQUIREMTIME(st->st_litemask);
-  if (inode.mask & INODE_MASK_ATIME) S_REQUIREATIME(st->st_litemask);
-  */
-
 
 int Client::lstat(const char *relpath, struct stat *stbuf)
 {
-- 
2.39.5