From 16be6ecb2013d28915708815c378fb946c2b55e7 Mon Sep 17 00:00:00 2001
From: Yehuda Sadeh <yehuda@redhat.com>
Date: Tue, 26 Nov 2019 13:20:30 -0800
Subject: [PATCH] rgw: remove unneeded #warnings

and other cleanups

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>
---
 src/rgw/rgw_data_sync.cc            | 4 ----
 src/rgw/services/svc_bi_rados.cc    | 1 -
 src/rgw/services/svc_bucket_sobj.cc | 1 -
 3 files changed, 6 deletions(-)

diff --git a/src/rgw/rgw_data_sync.cc b/src/rgw/rgw_data_sync.cc
index 02cb1c5b1a2..3ee7271e076 100644
--- a/src/rgw/rgw_data_sync.cc
+++ b/src/rgw/rgw_data_sync.cc
@@ -3739,7 +3739,6 @@ int RGWBucketShardFullSyncCR::operate()
         if (!marker_tracker.start(entry->key, total_entries, real_time())) {
           tn->log(0, SSTR("ERROR: cannot start syncing " << entry->key << ". Duplicate entry?"));
         } else {
-#warning look in here
           using SyncCR = RGWBucketSyncSingleEntryCR<rgw_obj_key, rgw_obj_key>;
           yield spawn(new SyncCR(sc, sync_pipe, entry->key,
                                  false, /* versioned, only matters for object removal */
@@ -4334,9 +4333,6 @@ int RGWRunBucketSourcesSyncCR::operate()
       }
     }
 
-#if 0
-    lease_cr->go_down();
-#endif
     drain_all();
     return set_cr_done();
   }
diff --git a/src/rgw/services/svc_bi_rados.cc b/src/rgw/services/svc_bi_rados.cc
index 5aac1ea47d5..3ef0b6f09c2 100644
--- a/src/rgw/services/svc_bi_rados.cc
+++ b/src/rgw/services/svc_bi_rados.cc
@@ -411,7 +411,6 @@ int RGWSI_BucketIndex_RADOS::get_reshard_status(const RGWBucketInfo& bucket_info
 int RGWSI_BucketIndex_RADOS::handle_overwrite(const RGWBucketInfo& info,
                                               const RGWBucketInfo& orig_info)
 {
-#warning needs to be done differently
   bool new_sync_enabled = info.datasync_flag_enabled();
   bool old_sync_enabled = orig_info.datasync_flag_enabled();
 
diff --git a/src/rgw/services/svc_bucket_sobj.cc b/src/rgw/services/svc_bucket_sobj.cc
index b276969e72d..122a74d5dfe 100644
--- a/src/rgw/services/svc_bucket_sobj.cc
+++ b/src/rgw/services/svc_bucket_sobj.cc
@@ -300,7 +300,6 @@ int RGWSI_Bucket_SObj::read_bucket_instance_info(RGWSI_Bucket_BI_Ctx& ctx,
                                   &ci, refresh_version, y);
   *info = e.info;
 
-#warning FIXME: use unique_ptr and implement RGWBucketInfo copy constructor, or other better solution
   if (info->sync_policy) { /* fork policy off cache */
     auto policy = make_shared<rgw_sync_policy_info>(*info->sync_policy);
     info->sync_policy = std::const_pointer_cast<const rgw_sync_policy_info>(policy);
-- 
2.39.5