From 185bc1c871ddce7892bee5af54adb798a782d38f Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 17 Jun 2020 17:20:51 +0800 Subject: [PATCH] teuthology: drop six.reraise() Signed-off-by: Kefu Chai --- teuthology/contextutil.py | 3 +-- teuthology/misc.py | 14 +++++++------- teuthology/parallel.py | 7 ++----- 3 files changed, 10 insertions(+), 14 deletions(-) diff --git a/teuthology/contextutil.py b/teuthology/contextutil.py index 7951478782..57a0f08c86 100644 --- a/teuthology/contextutil.py +++ b/teuthology/contextutil.py @@ -7,7 +7,6 @@ import itertools from teuthology.config import config from teuthology.exceptions import MaxWhileTries -from six import reraise log = logging.getLogger(__name__) @@ -53,7 +52,7 @@ def nested(*managers): # Don't rely on sys.exc_info() still containing # the right information. Another exception may # have been raised and caught by an exit method - reraise(*exc) + raise exc[1] class safe_while(object): diff --git a/teuthology/misc.py b/teuthology/misc.py index 08264ba98d..3257688904 100644 --- a/teuthology/misc.py +++ b/teuthology/misc.py @@ -9,7 +9,6 @@ import configobj import getpass import socket import subprocess -import sys import tarfile import time import yaml @@ -29,7 +28,8 @@ from teuthology.config import config from teuthology.contextutil import safe_while from teuthology.orchestra.opsys import DEFAULT_OS_VERSION -from six import (reraise, ensure_str) +from six import ensure_str + log = logging.getLogger(__name__) @@ -1179,17 +1179,17 @@ def stop_daemons_of_type(ctx, type_, cluster='ceph'): :param type_: type of daemons to be stopped. """ log.info('Shutting down %s daemons...' % type_) - exc_info = (None, None, None) + exc = None for daemon in ctx.daemons.iter_daemons_of_role(type_, cluster): try: daemon.stop() except (CommandFailedError, CommandCrashedError, - ConnectionLostError): - exc_info = sys.exc_info() + ConnectionLostError) as e: + exc = e log.exception('Saw exception from %s.%s', daemon.role, daemon.id_) - if exc_info != (None, None, None): - reraise(*exc_info) + if exc is not None: + raise exc def get_system_type(remote, distro=False, version=False): diff --git a/teuthology/parallel.py b/teuthology/parallel.py index a1cbb8df2e..0a7d3ab35a 100644 --- a/teuthology/parallel.py +++ b/teuthology/parallel.py @@ -5,7 +5,6 @@ import gevent import gevent.pool import gevent.queue -from six import reraise log = logging.getLogger(__name__) @@ -28,14 +27,12 @@ def capture_traceback(func, *args, **kwargs): def resurrect_traceback(exc): if isinstance(exc, ExceptionHolder): - exc_info = exc.exc_info + raise exc.exc_info[1] elif isinstance(exc, BaseException): - exc_info = (type(exc), exc, None) + raise exc else: return - reraise(*exc_info) - class parallel(object): """ -- 2.39.5