From 18fee5f62a2c68cf7690d5bb5b5c3a6a3974bb23 Mon Sep 17 00:00:00 2001 From: Alfredo Deza Date: Thu, 26 Apr 2018 16:26:30 -0400 Subject: [PATCH] ceph-volume util.prepare raise on non-zero exit status Signed-off-by: Alfredo Deza --- src/ceph-volume/ceph_volume/util/prepare.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/ceph-volume/ceph_volume/util/prepare.py b/src/ceph-volume/ceph_volume/util/prepare.py index 88e8328c02ee..93b913c3ca3e 100644 --- a/src/ceph-volume/ceph_volume/util/prepare.py +++ b/src/ceph-volume/ceph_volume/util/prepare.py @@ -322,7 +322,9 @@ def osd_mkfs_bluestore(osd_id, fsid, keyring=None, wal=False, db=False): command = base_command + supplementary_command - process.call(command, stdin=keyring, show_command=True) + _, _, returncode = process.call(command, stdin=keyring, show_command=True) + if returncode != 0: + raise RuntimeError('Command failed with exit code %s: %s' % (returncode, ' '.join(command))) def osd_mkfs_filestore(osd_id, fsid, keyring): @@ -360,4 +362,8 @@ def osd_mkfs_filestore(osd_id, fsid, keyring): '--setuser', 'ceph', '--setgroup', 'ceph' ] - process.call(command, stdin=keyring, terminal_verbose=True, show_command=True) + _, _, returncode = process.call( + command, stdin=keyring, terminal_verbose=True, show_command=True + ) + if returncode != 0: + raise RuntimeError('Command failed with exit code %s: %s' % (returncode, ' '.join(command))) -- 2.47.3