From 191e4e6f7e35b486e441ca6d821b822cd7595f08 Mon Sep 17 00:00:00 2001 From: Matan Breizman Date: Sun, 18 May 2025 11:40:52 +0300 Subject: [PATCH] scripts/build_utils: remove Debug build from Crimson See: https://github.com/ceph/ceph-build/pull/2167/files Builds should be set to Debug only when ending in "-debug". https://github.com/ceph/ceph-build/pull/1805 set Crimson to always use Debug. That made sense in earlier development phases. However, today we should align with Classical builds and use Debug only when needed. Signed-off-by: Matan Breizman --- ceph-source-dist/build/Jenkinsfile | 3 +-- scripts/build_utils.sh | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/ceph-source-dist/build/Jenkinsfile b/ceph-source-dist/build/Jenkinsfile index 6b1f13827..e08a838e2 100644 --- a/ceph-source-dist/build/Jenkinsfile +++ b/ceph-source-dist/build/Jenkinsfile @@ -14,8 +14,7 @@ pipeline { env.DEB_BUILD_PROFILES="" break case "crimson": - env.CEPH_EXTRA_RPMBUILD_ARGS="--with seastar" - env.CEPH_EXTRA_CMAKE_ARGS+=" -DCMAKE_BUILD_TYPE=Debug" + env.CEPH_EXTRA_RPMBUILD_ARGS="--with crimson" env.DEB_BUILD_PROFILES="pkg.ceph.crimson" break case "jaeger": diff --git a/scripts/build_utils.sh b/scripts/build_utils.sh index d1d32221e..d6da4d699 100755 --- a/scripts/build_utils.sh +++ b/scripts/build_utils.sh @@ -869,7 +869,6 @@ ceph_build_args_from_flavor() { ;; crimson) CEPH_EXTRA_RPMBUILD_ARGS="--with crimson" - CEPH_EXTRA_CMAKE_ARGS+=" -DCMAKE_BUILD_TYPE=Debug" DEB_BUILD_PROFILES="pkg.ceph.crimson" ;; jaeger) -- 2.47.3