From 193a900f286c7631fb2f771504a11add483e3fa0 Mon Sep 17 00:00:00 2001
From: Sage Weil <sage@redhat.com>
Date: Sat, 12 Oct 2019 11:55:12 -0500
Subject: [PATCH] ceph-daemon: deploy a logrotate.d config file for each
 cluster

By default this will be a no-op, since logging to files is off by default,
but should the user turn logs on, we should make sure they are rotated.

Signed-off-by: Sage Weil <sage@redhat.com>
---
 src/ceph-daemon | 33 ++++++++++++++++++++++++++++++++-
 1 file changed, 32 insertions(+), 1 deletion(-)

diff --git a/src/ceph-daemon b/src/ceph-daemon
index 6187936e1e0f9..0fd9904127d71 100755
--- a/src/ceph-daemon
+++ b/src/ceph-daemon
@@ -3,6 +3,7 @@
 DEFAULT_IMAGE='ceph/daemon-base'
 DATA_DIR='/var/lib/ceph'
 LOG_DIR='/var/log/ceph'
+LOGROTATE_DIR='/etc/logrotate.d'
 UNIT_DIR='/etc/systemd/system'
 LOG_DIR_MODE=0o770
 DATA_DIR_MODE=0o700
@@ -400,6 +401,31 @@ def install_base_units(fsid):
         subprocess.check_output(['systemctl', 'enable', 'ceph-%s.target' % fsid])
         subprocess.check_output(['systemctl', 'start', 'ceph-%s.target' % fsid])
 
+    # logrotate for the cluster
+    with open(args.logrotate_dir + '/ceph-%s' % fsid, 'w') as f:
+        """
+        This is a bit sloppy in that the killall/pkill will touch all ceph daemons
+        in all containers, but I don't see an elegant way to send SIGHUP *just* to
+        the daemons for this cluster.  (1) systemd kill -s will get the signal to
+        podman, but podman will exit.  (2) podman kill will get the signal to the
+        first child (bash), but that isn't the ceph daemon.  This is simpler and
+        should be harmless.
+        """
+        f.write("""# created by ceph-daemon
+/var/log/ceph/%s/*.log {
+    rotate 7
+    daily
+    compress
+    sharedscripts
+    postrotate
+        killall -q -1 ceph-mon ceph-mgr ceph-mds ceph-osd ceph-fuse radosgw || pkill -1 -x "ceph-mon|ceph-mgr|ceph-mds|ceph-osd|ceph-fuse|radosgw" || true
+    endscript
+    missingok
+    notifempty
+    su root ceph
+}
+""" % fsid)
+
 def deploy_crash(fsid, uid, gid, config, keyring):
     crash_dir = os.path.join(args.data_dir, fsid, 'crash')
     makedirs(crash_dir, uid, gid, DATA_DIR_MODE)
@@ -455,7 +481,6 @@ def deploy_crash(fsid, uid, gid, config, keyring):
         subprocess.check_output(['systemctl', 'enable', unit_name])
         subprocess.check_output(['systemctl', 'start', unit_name])
 
-
 def get_unit_file(fsid):
     u = """[Unit]
 Description=Ceph daemon for {fsid}
@@ -1141,6 +1166,8 @@ def command_rm_cluster():
     subprocess.check_output(['rm', '-rf', args.log_dir + '/' + args.fsid])
     subprocess.check_output(['rm', '-rf', args.log_dir +
                              '/*.wants/ceph-%s@*' % args.fsid])
+    # rm logrotate config
+    call_throws(['rm', '-f', args.logrotate_dir + '/ceph-%s' % args.fsid])
 
 
 ##################################
@@ -1164,6 +1191,10 @@ parser.add_argument(
     '--log-dir',
     default=LOG_DIR,
     help='base directory for daemon logs')
+parser.add_argument(
+    '--logrotate-dir',
+    default=LOGROTATE_DIR,
+    help='location of logrotate configuration files')
 parser.add_argument(
     '--unit-dir',
     default=UNIT_DIR,
-- 
2.39.5