From 1a49022fab9b4d5b57fcc041afbf7e4189948121 Mon Sep 17 00:00:00 2001 From: Dave Chinner Date: Wed, 27 Nov 2024 11:04:14 +1100 Subject: [PATCH] fstests: always use fail-at-unmount semantics for XFS Rather than require every test that tests unmount in failure conditions have to set up fail-at-unmount semantics for the underlying filesystem, use these semantics for all test and scratch device mounts. This currently only affects XFS filesystems, and helps prevent unexpected unmount hangs in EIO tests because metadata writes are configured to try forever by default. Signed-off-by: Dave Chinner Reviewed-by: Zorro lang Signed-off-by: Zorro Lang --- common/rc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/rc b/common/rc index 3ab75fc8..1b2e4508 100644 --- a/common/rc +++ b/common/rc @@ -434,6 +434,7 @@ _try_scratch_mount() mount_ret=$? [ $mount_ret -ne 0 ] && return $mount_ret _idmapped_mount $SCRATCH_DEV $SCRATCH_MNT + _prepare_for_eio_shutdown $SCRATCH_DEV } # mount scratch device with given options and _fail if mount fails @@ -633,6 +634,7 @@ _test_mount() mount_ret=$? [ $mount_ret -ne 0 ] && return $mount_ret _idmapped_mount $TEST_DEV $TEST_DIR + _prepare_for_eio_shutdown $TEST_DEV } _test_unmount() -- 2.39.5