From 1b8cdbee021ada4d8595905b3ee09dd5d8b675a2 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Thu, 16 Jul 2020 20:40:16 +0800 Subject: [PATCH] crimson: do not capture unused variables this change silences warnings like: mson/osd/backfill_state.cc:131:11: warning: lambda capture 'this' is not used [-Wunused-lambda-capture] [&, this](const pg_log_entry_t& e) { ~~^~~~ Signed-off-by: Kefu Chai --- src/crimson/osd/backfill_state.cc | 6 +++--- src/crimson/osd/osd.cc | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/crimson/osd/backfill_state.cc b/src/crimson/osd/backfill_state.cc index 7c66013e18c99..1ffadd4e8483c 100644 --- a/src/crimson/osd/backfill_state.cc +++ b/src/crimson/osd/backfill_state.cc @@ -128,7 +128,7 @@ void BackfillState::Enqueuing::maybe_update_range() pg().get_projected_last_update()); logger().debug("{}: scanning pg log first", __func__); peering_state().get_pg_log().get_log().scan_log_after(primary_bi.version, - [&, this](const pg_log_entry_t& e) { + [&](const pg_log_entry_t& e) { logger().debug("maybe_update_range(lambda): updating from version {}", e.version); if (e.soid >= primary_bi.begin && e.soid < primary_bi.end) { @@ -198,7 +198,7 @@ bool BackfillState::Enqueuing::should_rescan_replicas( { const auto& targets = peering_state().get_backfill_targets(); return std::any_of(std::begin(targets), std::end(targets), - [&, this] (const auto& bt) { + [&] (const auto& bt) { return ReplicasScanning::replica_needs_scan(peer_backfill_info.at(bt), backfill_info); }); @@ -218,7 +218,7 @@ void BackfillState::Enqueuing::trim_backfilled_object_from_intervals( std::map& peer_backfill_info) { std::for_each(std::begin(result.pbi_targets), std::end(result.pbi_targets), - [this, &peer_backfill_info] (const auto& bt) { + [&peer_backfill_info] (const auto& bt) { peer_backfill_info.at(bt).pop_front(); }); last_backfill_started = std::move(result.new_last_backfill_started); diff --git a/src/crimson/osd/osd.cc b/src/crimson/osd/osd.cc index e4fb16cc9f11e..8f6b14ec72e84 100644 --- a/src/crimson/osd/osd.cc +++ b/src/crimson/osd/osd.cc @@ -1055,7 +1055,7 @@ seastar::future<> OSD::send_incremental_map(crimson::net::Connection* conn, }); } else { return load_map_bl(osdmap->get_epoch()) - .then([this, conn, first](auto&& bl) mutable { + .then([this, conn](auto&& bl) mutable { auto m = make_message(monc->get_fsid(), osdmap->get_encoding_features()); m->oldest_map = superblock.oldest_map; -- 2.47.3