From 1c0e6e7c8d2181e6cc2f69cb1ab8c988f5279b96 Mon Sep 17 00:00:00 2001 From: Chunmei Liu Date: Tue, 10 Aug 2021 20:22:17 -0700 Subject: [PATCH] crimson/seastore: change unit test using hint Signed-off-by: Chunmei Liu --- .../seastore/onode_tree/test_fltree_onode_manager.cc | 6 +++--- src/test/crimson/seastore/onode_tree/test_staged_fltree.cc | 6 +++--- src/test/crimson/seastore/test_object_data_handler.cc | 1 + src/test/crimson/seastore/test_omap_manager.cc | 2 +- 4 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/test/crimson/seastore/onode_tree/test_fltree_onode_manager.cc b/src/test/crimson/seastore/onode_tree/test_fltree_onode_manager.cc index 80122d9eb4275..846b6fc9c71ec 100644 --- a/src/test/crimson/seastore/onode_tree/test_fltree_onode_manager.cc +++ b/src/test/crimson/seastore/onode_tree/test_fltree_onode_manager.cc @@ -31,15 +31,15 @@ struct onode_item_t { void initialize(Transaction& t, Onode& value) const { auto& layout = value.get_mutable_layout(t); layout.size = size; - layout.omap_root.update(omap_root_t(id, cnt_modify)); + layout.omap_root.update(omap_root_t(id, cnt_modify, value.get_hint())); validate(value); } void validate(Onode& value) const { auto& layout = value.get_layout(); ceph_assert(laddr_t(layout.size) == laddr_t{size}); - ceph_assert(layout.omap_root.get().addr == id); - ceph_assert(layout.omap_root.get().depth == cnt_modify); + ceph_assert(layout.omap_root.get(value.get_hint()).addr == id); + ceph_assert(layout.omap_root.get(value.get_hint()).depth == cnt_modify); } void modify(Transaction& t, Onode& value) { diff --git a/src/test/crimson/seastore/onode_tree/test_staged_fltree.cc b/src/test/crimson/seastore/onode_tree/test_staged_fltree.cc index 24e314fb1d171..771e5b0356904 100644 --- a/src/test/crimson/seastore/onode_tree/test_staged_fltree.cc +++ b/src/test/crimson/seastore/onode_tree/test_staged_fltree.cc @@ -42,7 +42,7 @@ using namespace crimson::os::seastore::onode; with_trans_intr( \ c.t, \ [=] (auto &t) { \ - return fun(c, b, v); \ + return fun(c, L_ADDR_MIN, b, v); \ } \ ) @@ -908,7 +908,7 @@ class DummyChildPool { ceph_abort("impossible path"); } search_position_t merge(NodeExtentMutable&, NodeImpl&, match_stage_t, extent_len_t) override { ceph_abort("impossible path"); } - eagain_ifuture rebuild_extent(context_t) override { + eagain_ifuture rebuild_extent(context_t, laddr_t) override { ceph_abort("impossible path"); } node_stats_t get_stats() const override { ceph_abort("impossible path"); } @@ -1062,7 +1062,7 @@ class DummyChildPool { crimson::ct_error::assert_all{"Invalid error during create_initial()"} ).si_then([c, initial](auto super) { initial->make_root_new(c, std::move(super)); - return initial->upgrade_root(c).si_then([initial] { + return initial->upgrade_root(c, L_ADDR_MIN).si_then([initial] { return initial; }); }); diff --git a/src/test/crimson/seastore/test_object_data_handler.cc b/src/test/crimson/seastore/test_object_data_handler.cc index f30cd7a9ff2a3..e2fac7f68f1a0 100644 --- a/src/test/crimson/seastore/test_object_data_handler.cc +++ b/src/test/crimson/seastore/test_object_data_handler.cc @@ -30,6 +30,7 @@ public: return layout; } bool is_dirty() const { return dirty; } + laddr_t get_hint() const final {return L_ADDR_MIN; } ~TestOnode() final = default; }; diff --git a/src/test/crimson/seastore/test_omap_manager.cc b/src/test/crimson/seastore/test_omap_manager.cc index e267b44e76f33..233d8ac5fd190 100644 --- a/src/test/crimson/seastore/test_omap_manager.cc +++ b/src/test/crimson/seastore/test_omap_manager.cc @@ -219,7 +219,7 @@ struct omap_manager_test_t : omap_root_t omap_root = with_trans_intr( *t, [this](auto &t) { - return omap_manager->initialize_omap(t); + return omap_manager->initialize_omap(t, L_ADDR_MIN); }).unsafe_get0(); submit_transaction(std::move(t)); return omap_root; -- 2.39.5