From 1c8c96cc8b265d5b55bbadd3e2d6057c72a6cc11 Mon Sep 17 00:00:00 2001 From: Radoslaw Zarzynski Date: Tue, 22 Jan 2019 19:59:46 +0100 Subject: [PATCH] auth: drop no_security() from AuthSessionHandler. Signed-off-by: Radoslaw Zarzynski --- src/auth/AuthSessionHandler.h | 1 - src/auth/cephx/CephxSessionHandler.h | 4 ---- src/auth/krb/KrbSessionHandler.hpp | 2 +- src/auth/none/AuthNoneSessionHandler.h | 4 ---- src/auth/unknown/AuthUnknownSessionHandler.h | 4 ---- 5 files changed, 1 insertion(+), 14 deletions(-) diff --git a/src/auth/AuthSessionHandler.h b/src/auth/AuthSessionHandler.h index fa1518692d277..76e31a003a306 100644 --- a/src/auth/AuthSessionHandler.h +++ b/src/auth/AuthSessionHandler.h @@ -45,7 +45,6 @@ public: connection_secret(cs_) {} virtual ~AuthSessionHandler() { } - virtual bool no_security() = 0; virtual int sign_message(Message *message) = 0; virtual int check_message_signature(Message *message) = 0; virtual int encrypt_message(Message *message) = 0; diff --git a/src/auth/cephx/CephxSessionHandler.h b/src/auth/cephx/CephxSessionHandler.h index 5f7bfa5927871..0def90cbed26f 100644 --- a/src/auth/cephx/CephxSessionHandler.h +++ b/src/auth/cephx/CephxSessionHandler.h @@ -31,10 +31,6 @@ public: features(features) {} ~CephxSessionHandler() override {} - bool no_security() override { - return false; - } - int _calc_signature(Message *m, uint64_t *psig); int sign_message(Message *m) override; diff --git a/src/auth/krb/KrbSessionHandler.hpp b/src/auth/krb/KrbSessionHandler.hpp index c5fd2de4c1595..fcfe4b8452245 100644 --- a/src/auth/krb/KrbSessionHandler.hpp +++ b/src/auth/krb/KrbSessionHandler.hpp @@ -43,7 +43,7 @@ class KrbSessionHandler : public AuthSessionHandler { connection_secret) { } ~KrbSessionHandler() override = default; - bool no_security() override { return true; } + // No security int sign_message(Message* msg) override { return 0; } int check_message_signature(Message* msg) override { return 0; } int encrypt_message(Message* msg) override { return 0; } diff --git a/src/auth/none/AuthNoneSessionHandler.h b/src/auth/none/AuthNoneSessionHandler.h index fca01ac2d4232..63ff7974daadf 100644 --- a/src/auth/none/AuthNoneSessionHandler.h +++ b/src/auth/none/AuthNoneSessionHandler.h @@ -25,10 +25,6 @@ public: : AuthSessionHandler(cct_, CEPH_AUTH_NONE, session_key, connection_secret) {} ~AuthNoneSessionHandler() override {} - bool no_security() override { - return true; - } - // The None suite neither signs nor encrypts messages, so these functions just return success. // Since nothing was signed or encrypted, don't increment the stats. PLR diff --git a/src/auth/unknown/AuthUnknownSessionHandler.h b/src/auth/unknown/AuthUnknownSessionHandler.h index b10320debda15..637176ed9c1a0 100644 --- a/src/auth/unknown/AuthUnknownSessionHandler.h +++ b/src/auth/unknown/AuthUnknownSessionHandler.h @@ -28,10 +28,6 @@ public: session_key, connection_secret) {} ~AuthUnknownSessionHandler() override {} - bool no_security() override { - return true; - } - // The Unknown suite neither signs nor encrypts messages, so these functions just return success. // Since nothing was signed or encrypted, don't increment the stats. PLR -- 2.39.5