From 1d084e48be5e4c80fd9bd619ed38baa5b8d126fd Mon Sep 17 00:00:00 2001 From: Tiago Melo Date: Thu, 7 Feb 2019 15:38:21 +0000 Subject: [PATCH] mgr/dashboard: Add iSCSI target edit UI Fixes: http://tracker.ceph.com/issues/38014 Signed-off-by: Tiago Melo --- .../frontend/src/app/app-routing.module.ts | 7 +- .../iscsi-target-form.component.html | 34 +- .../iscsi-target-form.component.spec.ts | 141 ++++++--- .../iscsi-target-form.component.ts | 292 +++++++++++++----- .../iscsi-target-list.component.spec.ts | 36 ++- .../iscsi-target-list.component.ts | 8 +- .../src/app/shared/api/iscsi.service.spec.ts | 17 +- .../src/app/shared/api/iscsi.service.ts | 14 +- .../frontend/src/locale/messages.xlf | 56 ++-- 9 files changed, 423 insertions(+), 182 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts b/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts index 908e398398c6a..7b9e81b578059 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts @@ -200,7 +200,12 @@ const routes: Routes = [ data: { breadcrumbs: 'Targets' }, children: [ { path: '', component: IscsiTargetListComponent }, - { path: 'add', component: IscsiTargetFormComponent, data: { breadcrumbs: 'Add' } } + { path: 'add', component: IscsiTargetFormComponent, data: { breadcrumbs: 'Add' } }, + { + path: 'edit/:target_iqn', + component: IscsiTargetFormComponent, + data: { breadcrumbs: 'Edit' } + } ] } ] diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.html index 00b7b78eeccbe..750173873ae7f 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/iscsi-target-form/iscsi-target-form.component.html @@ -8,7 +8,7 @@

Create target

+ i18n>{isEdit, select, 1 {Edit} other {Add}} target
@@ -175,13 +175,13 @@
+ *ngFor="let initiator of initiators.controls; let ii = index" + [formGroupName]="ii">
Initiator: {{ initiator.getValue('client_iqn') }}
@@ -340,7 +340,7 @@ for="luns" i18n>Images
- +
@@ -364,7 +364,7 @@ *ngIf="!initiator.getValue('cdIsInGroup')">
@@ -383,7 +383,7 @@ *ngIf="initiators.controls.length === 0" i18n>No items added. -
@@ -446,7 +446,7 @@ @@ -457,7 +457,7 @@
@@ -488,7 +488,7 @@ @@ -499,7 +499,7 @@
@@ -520,7 +520,7 @@ *ngIf="groups.controls.length === 0" i18n>No items added. -