From 1de43e00639b5e53ac2bf19e6625350209fca2b0 Mon Sep 17 00:00:00 2001 From: Somnath Roy Date: Mon, 8 Sep 2014 18:59:01 -0700 Subject: [PATCH] OpTracker: Removed _dump_op_descriptor_unlocked call for log level < 5 _dump_op_descriptor_unlocked call within the function _mark_event() was invoked unnecessarily every time for all log levels. This was degrading performance significantly! The stream is only used during log level 5 and thus the _dump_op_descriptor_unlocked() is only called now if user sets the log level to 5 and beyond. Signed-off-by: Somnath Roy --- src/common/TrackedOp.cc | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/common/TrackedOp.cc b/src/common/TrackedOp.cc index 8590c588f2d..d7a95b87ac1 100644 --- a/src/common/TrackedOp.cc +++ b/src/common/TrackedOp.cc @@ -283,12 +283,13 @@ void OpTracker::mark_event(TrackedOp *op, const string &dest, utime_t time) void OpTracker::_mark_event(TrackedOp *op, const string &evt, utime_t time) { - stringstream ss; - op->_dump_op_descriptor_unlocked(ss); - dout(5) << //"reqid: " << op->get_reqid() << - ", seq: " << op->seq + dout(5); + *_dout << "seq: " << op->seq << ", time: " << time << ", event: " << evt - << ", op: " << ss.str() << dendl; + << ", op: "; + op->_dump_op_descriptor_unlocked(*_dout); + *_dout << dendl; + } void OpTracker::RemoveOnDelete::operator()(TrackedOp *op) { -- 2.47.3