From 1e3df88ce15a860f71c44b2d4b5389394e0ffe87 Mon Sep 17 00:00:00 2001 From: haoyixing Date: Thu, 17 Dec 2020 16:07:47 +0800 Subject: [PATCH] MDSLogContext: fix typo in MDSLogContextBase and add more comments Fix typos in MDSLogContextBase's definition and function '::complete', also add more comments about setting safe_pos. Signed-off-by: haoyixing --- src/mds/MDSContext.cc | 3 ++- src/mds/MDSContext.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mds/MDSContext.cc b/src/mds/MDSContext.cc index c702d0253f74f..a17da0a01f0ac 100644 --- a/src/mds/MDSContext.cc +++ b/src/mds/MDSContext.cc @@ -119,8 +119,9 @@ void MDSLogContextBase::complete(int r) { MDLog *mdlog = get_mds()->mdlog; uint64_t safe_pos = write_pos; pre_finish(r); - // MDSContextBase::complete() free this + // MDSIOContext::complete() free this MDSIOContextBase::complete(r); + // safe_pos must be updated after MDSIOContext::complete() call mdlog->set_safe_pos(safe_pos); } diff --git a/src/mds/MDSContext.h b/src/mds/MDSContext.h index d544115b9b51a..319af50d35426 100644 --- a/src/mds/MDSContext.h +++ b/src/mds/MDSContext.h @@ -118,7 +118,7 @@ private: /** * Completion for an log operation, takes big MDSRank lock * before executing finish function. Update log's safe pos - * after finish functuon return. + * after finish function return. */ class MDSLogContextBase : public MDSIOContextBase { -- 2.39.5