From 1f1398bc515b389fd423435fc3d8bfeb927d8af4 Mon Sep 17 00:00:00 2001 From: "Adam C. Emerson" Date: Wed, 28 Sep 2022 19:57:16 -0400 Subject: [PATCH] mon: Fix snprintf truncation warning by switching to fmtlib Signed-off-by: Adam C. Emerson --- src/mds/cephfs_features.cc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mds/cephfs_features.cc b/src/mds/cephfs_features.cc index dda64edfcd2..61c442699a5 100644 --- a/src/mds/cephfs_features.cc +++ b/src/mds/cephfs_features.cc @@ -5,6 +5,10 @@ #include "cephfs_features.h" #include "mdstypes.h" +#undef FMT_HEADER_ONLY +#define FMT_HEADER_ONLY 1 +#include + static const std::array feature_names { "reserved", @@ -69,9 +73,7 @@ void cephfs_dump_features(ceph::Formatter *f, const feature_bitset_t& features) for (size_t i = 0; i < feature_names.size(); ++i) { if (!features.test(i)) continue; - char s[18]; - snprintf(s, sizeof(s), "feature_%zu", i); - f->dump_string(s, cephfs_feature_name(i)); + f->dump_string(fmt::format("feature_{}", i), + cephfs_feature_name(i)); } } - -- 2.47.3