From 200349736ed69a6c15b0f87fc3c9b7766c109323 Mon Sep 17 00:00:00 2001
From: sageweil <sageweil@29311d96-e01e-0410-9327-a35deaab8ce9>
Date: Fri, 10 Aug 2007 16:18:55 +0000
Subject: [PATCH] client fuse work

git-svn-id: https://ceph.svn.sf.net/svnroot/ceph@1617 29311d96-e01e-0410-9327-a35deaab8ce9
---
 branches/sage/mds/client/Client.cc  | 254 +++++++++++++++++-----------
 branches/sage/mds/client/Client.h   |  47 ++---
 branches/sage/mds/client/fuse.cc    |  18 +-
 branches/sage/mds/client/fuse_ll.cc |  29 +++-
 4 files changed, 216 insertions(+), 132 deletions(-)

diff --git a/branches/sage/mds/client/Client.cc b/branches/sage/mds/client/Client.cc
index 9c7cfb97fdb48..887e3be1f2705 100644
--- a/branches/sage/mds/client/Client.cc
+++ b/branches/sage/mds/client/Client.cc
@@ -117,7 +117,7 @@ Client::Client(Messenger *m, MonMap *mm) : timer(client_lock)
   lru.lru_set_max(g_conf.client_cache_size);
 
   // file handles
-  free_fh_set.insert(10, 1<<30);
+  free_fd_set.insert(10, 1<<30);
 
   // set up messengers
   messenger = m;
@@ -155,16 +155,16 @@ Client::~Client()
 
 void Client::tear_down_cache()
 {
-  // fh's
-  for (hash_map<fh_t, Fh*>::iterator it = fh_map.begin();
-       it != fh_map.end();
+  // fd's
+  for (hash_map<int, Fh*>::iterator it = fd_map.begin();
+       it != fd_map.end();
        it++) {
     Fh *fh = it->second;
     dout(1) << "tear_down_cache forcing close of fh " << it->first << " ino " << fh->inode->inode.ino << endl;
     put_inode(fh->inode);
     delete fh;
   }
-  fh_map.clear();
+  fd_map.clear();
 
   // caps!
   // *** FIXME ***
@@ -621,6 +621,7 @@ MClientReply *Client::make_request(MClientRequest *req,
 	dout(10) << "chose target mds" << mds << " based on hierarchy" << endl;
       } else {
 	mds = mdsmap->get_random_in_mds();
+	if (mds < 0) mds = 0;  // hrm.
 	dout(10) << "chose random target mds" << mds << " for lack of anything better" << endl;
       }
     }
@@ -1369,8 +1370,8 @@ int Client::mount()
   dout(3) << "op: int readlinkbuf_len = 1000;" << endl;
   dout(3) << "op: char readlinkbuf[readlinkbuf_len];" << endl;
   dout(3) << "op: map<string, inode_t*> dir_contents;" << endl;
-  dout(3) << "op: map<fh_t, fh_t> open_files;" << endl;
-  dout(3) << "op: fh_t fh;" << endl;
+  dout(3) << "op: map<int, int> open_files;" << endl;
+  dout(3) << "op: int fd;" << endl;
   */
   return 0;
 }
@@ -1389,7 +1390,7 @@ int Client::unmount()
   unmounting = true;
 
   // NOTE: i'm assuming all caches are already flushing (because all files are closed).
-  assert(fh_map.empty());
+  assert(fd_map.empty());
   
   // empty lru cache
   lru.lru_set_max(0);
@@ -1725,7 +1726,7 @@ int Client::_readlink(const char *path, char *buf, off_t size)
   tout << path << endl;
 
   Inode *in;
-  int r = _lstat(path, STAT_MASK_BASE, &in);
+  int r = _do_lstat(path, STAT_MASK_BASE, &in);
   if (r == 0 && !in->inode.is_symlink()) r = -EINVAL;
   if (r == 0) {
     // copy into buf (at most size bytes)
@@ -1745,7 +1746,7 @@ int Client::_readlink(const char *path, char *buf, off_t size)
 
 // inode stuff
 
-int Client::_lstat(const char *path, int mask, Inode **in)
+int Client::_do_lstat(const char *path, int mask, Inode **in)
 {  
   MClientRequest *req = 0;
   filepath fpath(path);
@@ -1804,7 +1805,8 @@ int Client::_lstat(const char *path, int mask, Inode **in)
 
 int Client::fill_stat(Inode *in, struct stat *st) 
 {
-  dout(10) << "fill_stat on " << in->inode.ino << " mode " << oct << in->inode.mode << dec << endl;
+  dout(10) << "fill_stat on " << in->inode.ino << " mode " << oct << in->inode.mode << dec
+	   << " mtime " << in->inode.mtime << " ctime " << in->inode.ctime << endl;
   memset(st, 0, sizeof(struct stat));
   st->st_ino = in->inode.ino;
   st->st_mode = in->inode.mode;
@@ -1835,17 +1837,19 @@ int Client::fill_stat(Inode *in, struct stat *st)
 
 int Client::lstat(const char *relpath, struct stat *stbuf)
 {
-  client_lock.Lock();
-
-  tout << "lstat" << endl;
-  tout << relpath << endl;
-
+  Mutex::Locker lock(client_lock);
   string abspath;
   mkabspath(relpath, abspath);
-  const char *path = abspath.c_str();
+  return _lstat(abspath.c_str(), stbuf);
+}
+
+int Client::_lstat(const char *path, struct stat *stbuf)
+{
+  tout << "lstat" << endl;
+  tout << path << endl;
 
   Inode *in = 0;
-  int res = _lstat(path, STAT_MASK_ALL, &in);
+  int res = _do_lstat(path, STAT_MASK_ALL, &in);
   if (res == 0) {
     assert(in);
     fill_stat(in, stbuf);
@@ -1853,8 +1857,7 @@ int Client::lstat(const char *relpath, struct stat *stbuf)
   }
 
   trim_cache();
-  dout(3) << "lstat(\"" << relpath << "\", " << stbuf << ") = " << res << endl;
-  client_lock.Unlock();
+  dout(3) << "lstat(\"" << path << "\", " << stbuf << ") = " << res << endl;
   return res;
 }
 
@@ -2073,7 +2076,7 @@ int Client::opendir(const char *name, DIR **dirpp)
   if (dn && dn->inode) {
     dirp->inode = dn->inode;
     dirp->inode->get();
-    dout(10) << "got inode " << dn->inode->inode.ino << " ref now " << dn->inode->ref << endl;
+    dout(10) << "had inode " << dn->inode->inode.ino << " ref now " << dn->inode->ref << endl;
     dirp->set_frag(dn->inode->dirfragtree[0]);
     dout(10) << "opendir " << name << ", our cache says the first dirfrag is " << dirp->frag() << endl;
   }
@@ -2314,11 +2317,12 @@ void Client::_readdir_fill_dirent(struct dirent *de, DirEntry *entry, off_t off)
 
 int Client::closedir(DIR *dir) 
 {
+  Mutex::Locker lock(client_lock);
+
   dout(3) << "closedir(" << dir << ") = 0" << endl;
 
   DirResult *dirp = (DirResult*)dir;
   if (dirp->inode) {
-    Mutex::Locker lock(client_lock);
     put_inode(dirp->inode);
     dirp->inode = 0;
   }
@@ -2368,9 +2372,9 @@ int Client::open(const char *relpath, int flags, mode_t mode)
   if (r >= 0) {
     // allocate a integer file descriptor
     assert(fh);
-    r = get_fh();
-    assert(fh_map.count(r) == 0);
-    fh_map[r] = fh;
+    r = get_fd();
+    assert(fd_map.count(r) == 0);
+    fd_map[r] = fh;
   } 
   dout(3) << "open(" << relpath << ", " << flags << ") = " << r << endl;
   return r;
@@ -2497,14 +2501,14 @@ void Client::close_safe(Inode *in)
 }
 
 
-int Client::close(fh_t fd)
+int Client::close(int fd)
 {
   Mutex::Locker lock(client_lock);
   dout(3) << "close(" << fd << ")" << endl;
-  assert(fh_map.count(fd));
-  Fh *fh = fh_map[fd];
+  assert(fd_map.count(fd));
+  Fh *fh = fd_map[fd];
   _release(fh);
-  fh_map.erase(fd);
+  fd_map.erase(fd);
   return 0;
 }
 
@@ -2570,12 +2574,12 @@ int Client::_release(Fh *f)
 // read, write
 
 
-off_t Client::lseek(fh_t fh, off_t offset, int whence)
+off_t Client::lseek(int fd, off_t offset, int whence)
 {
   Mutex::Locker lock(client_lock);
 
-  assert(fh_map.count(fh));
-  Fh *f = fh_map[fh];
+  assert(fd_map.count(fd));
+  Fh *f = fd_map[fd];
   Inode *in = f->inode;
 
   switch (whence) {
@@ -2597,7 +2601,7 @@ off_t Client::lseek(fh_t fh, off_t offset, int whence)
   
   off_t pos = f->pos;
 
-  dout(3) << "lseek(" << fh << ", " << offset << ", " << whence << ") = " << pos << endl;
+  dout(3) << "lseek(" << fd << ", " << offset << ", " << whence << ") = " << pos << endl;
   return pos;
 }
 
@@ -2630,14 +2634,14 @@ void Client::unlock_fh_pos(Fh *f)
 
 // blocking osd interface
 
-int Client::read(fh_t fh, char *buf, off_t size, off_t offset) 
+int Client::read(int fd, char *buf, off_t size, off_t offset) 
 {
   Mutex::Locker lock(client_lock);
-  assert(fh_map.count(fh));
-  Fh *f = fh_map[fh];
+  assert(fd_map.count(fd));
+  Fh *f = fd_map[fd];
   bufferlist bl;
   int r = _read(f, offset, size, &bl);
-  dout(3) << "read(" << fh << ", " << buf << ", " << size << ", " << offset << ") = " << r << endl;
+  dout(3) << "read(" << fd << ", " << buf << ", " << size << ", " << offset << ") = " << r << endl;
   if (r >= 0) {
     bl.copy(0, bl.length(), buf);
     r = bl.length();
@@ -2766,11 +2770,11 @@ void Client::hack_sync_write_safe()
   client_lock.Unlock();
 }
 
-int Client::write(fh_t fd, const char *buf, off_t size, off_t offset) 
+int Client::write(int fd, const char *buf, off_t size, off_t offset) 
 {
   Mutex::Locker lock(client_lock);
-  assert(fh_map.count(fd));
-  Fh *fh = fh_map[fd];
+  assert(fd_map.count(fd));
+  Fh *fh = fd_map[fd];
   int r = _write(fh, offset, size, buf);
   dout(3) << "write(" << fd << ", \"...\", " << size << ", " << offset << ") = " << r << endl;
   return r;
@@ -2921,12 +2925,43 @@ int Client::_truncate(const char *file, off_t length)
   return res;
 }
 
+int Client::ftruncate(int fd, off_t length) 
+{
+  Mutex::Locker lock(client_lock);
+  assert(fd_map.count(fd));
+  Fh *f = fd_map[fd];
+  return _ftruncate(f, length);
+}
+
+int Client::_ftruncate(Fh *fh, off_t length) 
+{
+  tout << "ftruncate" << endl;
+  tout << (long)fh << endl;
+  tout << length << endl;
+
+  MClientRequest *req = new MClientRequest(MDS_OP_TRUNCATE, messenger->get_myinst());
+  req->args.truncate.ino = fh->inode->inode.ino;
+  req->args.truncate.length = length;
+
+  // FIXME where does FUSE maintain user information
+  req->set_caller_uid(getuid());
+  req->set_caller_gid(getgid());
+  
+  MClientReply *reply = make_request(req);
+  int res = reply->get_result();
+  insert_trace(reply);  
+  delete reply;
+
+  dout(3) << "ftruncate(\"" << fh << "\", " << length << ") = " << res << endl;
+  return res;
+}
+
 
-int Client::fsync(fh_t fd, bool syncdataonly) 
+int Client::fsync(int fd, bool syncdataonly) 
 {
   Mutex::Locker lock(client_lock);
-  assert(fh_map.count(fd));
-  Fh *f = fh_map[fd];
+  assert(fd_map.count(fd));
+  Fh *f = fd_map[fd];
   int r = _fsync(f, syncdataonly);
   dout(3) << "fsync(" << fd << ", " << syncdataonly << ") = " << r << endl;
   return r;
@@ -2995,8 +3030,8 @@ int Client::lazyio_propogate(int fd, off_t offset, size_t count)
   dout(3) << "op: client->lazyio_propogate(" << fd
           << ", " << offset << ", " << count << ")" << endl;
   
-  assert(fh_map.count(fd));
-  Fh *f = fh_map[fd];
+  assert(fd_map.count(fd));
+  Fh *f = fd_map[fd];
   Inode *in = f->inode;
 
   if (f->mode & FILE_MODE_LAZY) {
@@ -3031,8 +3066,8 @@ int Client::lazyio_synchronize(int fd, off_t offset, size_t count)
   dout(3) << "op: client->lazyio_synchronize(" << fd
           << ", " << offset << ", " << count << ")" << endl;
   
-  assert(fh_map.count(fd));
-  Fh *f = fh_map[fd];
+  assert(fd_map.count(fd));
+  Fh *f = fd_map[fd];
   Inode *in = f->inode;
   
   if (f->mode & FILE_MODE_LAZY) {
@@ -3070,8 +3105,7 @@ int Client::lazyio_synchronize(int fd, off_t offset, size_t count)
 #define FUSE_SET_ATTR_ATIME	(1 << 4)
 #define FUSE_SET_ATTR_MTIME	(1 << 5)
 
-int Client::ll_lookup(inodeno_t parent, const char *name, struct stat *attr,
-		      double *attr_timeout, double *entry_timeout)
+int Client::ll_lookup(inodeno_t parent, const char *name, struct stat *attr)
 {
   Mutex::Locker lock(client_lock);
   dout(3) << "ll_lookup " << parent << " " << name << endl;
@@ -3111,10 +3145,7 @@ int Client::ll_lookup(inodeno_t parent, const char *name, struct stat *attr,
   if (diri->dir &&
       diri->dir->dentries.count(dname)) {
     Inode *in = diri->dir->dentries[dname]->inode;
-    attr->st_ino = in->inode.ino;
-    attr->st_mode = in->inode.mode;
-    attr_timeout = 0;
-    entry_timeout = 0;
+    fill_stat(in, attr);
     in->get();
     dout(3) << "ll_lookup " << parent << " " << name << " -> " << in->inode.ino << endl;
     return 0;
@@ -3145,7 +3176,7 @@ Inode *Client::_ll_get_inode(inodeno_t ino)
   if (inode_map.count(ino) == 0) {
     assert(ino == 1);  // must be the root inode.
     Inode *in;
-    int r = _lstat("/", 0, &in);
+    int r = _do_lstat("/", 0, &in);
     assert(r >= 0);
     return in;
   } else {
@@ -3154,7 +3185,7 @@ Inode *Client::_ll_get_inode(inodeno_t ino)
 }
 
 
-int Client::ll_getattr(inodeno_t ino, struct stat *st, double *attr_timeout)
+int Client::ll_getattr(inodeno_t ino, struct stat *st)
 {
   Mutex::Locker lock(client_lock);
   dout(3) << "ll_getattr " << ino << endl;
@@ -3175,17 +3206,24 @@ int Client::ll_setattr(inodeno_t ino, struct stat *st, int mask)
   int r;
   if ((mask & FUSE_SET_ATTR_MODE) &&
       (r = _chmod(path.c_str(), st->st_mode) < 0)) return r;
+
   if ((mask & FUSE_SET_ATTR_UID) &&
       (r = _chown(path.c_str(), st->st_uid, st->st_gid) < 0)) return r;
   //if ((mask & FUSE_SET_ATTR_GID) &&
   //(r = client->_chgrp(path.c_str(), st->st_gid) < 0)) return r;
+
   if ((mask & FUSE_SET_ATTR_SIZE) &&
       (r = _truncate(path.c_str(), st->st_size) < 0)) return r;
+  
   if ((mask & FUSE_SET_ATTR_MTIME) &&
+      (mask & FUSE_SET_ATTR_ATIME) &&
+      (r = _utime(path.c_str(), utime_t(st->st_mtime,0), utime_t(st->st_atime,0)) < 0)) return r;
+  else if ((mask & FUSE_SET_ATTR_MTIME) &&
       (r = _utime(path.c_str(), utime_t(st->st_mtime,0), utime_t()) < 0)) return r;
-  if ((mask & FUSE_SET_ATTR_ATIME) &&
+  else if ((mask & FUSE_SET_ATTR_ATIME) &&
       (r = _utime(path.c_str(), utime_t(), utime_t(st->st_atime,0)) < 0)) return r;
   
+  dout(3) << "ll_setattr " << ino << " = " << r << endl;
   return 0;
 }
 
@@ -3213,12 +3251,14 @@ int Client::ll_mknod(inodeno_t parent, const char *name, mode_t mode, dev_t rdev
   path += "/";
   path += name;
   int r = _mknod(path.c_str(), mode, rdev);
-  if (r < 0) return r;
-
-  string dname(name);
-  Inode *in = diri->dir->dentries[dname]->inode;
-  fill_stat(in, attr);
-  return 0;
+  if (r == 0) {
+    string dname(name);
+    Inode *in = diri->dir->dentries[dname]->inode;
+    in->get();
+    fill_stat(in, attr);
+  }
+  dout(3) << "ll_mknod " << parent << " " << name << " = " << r << endl;
+  return r;
 }
 
 int Client::ll_mkdir(inodeno_t parent, const char *name, mode_t mode, struct stat *attr)
@@ -3232,12 +3272,14 @@ int Client::ll_mkdir(inodeno_t parent, const char *name, mode_t mode, struct sta
   path += "/";
   path += name;
   int r = _mkdir(path.c_str(), mode);
-  if (r < 0) return r;
-
-  string dname(name);
-  Inode *in = diri->dir->dentries[dname]->inode;
-  fill_stat(in, attr);
-  return 0;
+  if (r == 0) {
+    string dname(name);
+    Inode *in = diri->dir->dentries[dname]->inode;
+    in->get();
+    fill_stat(in, attr);
+  }
+  dout(3) << "ll_mkdir " << parent << " " << name << " = " << r << endl;
+  return r;
 }
 
 int Client::ll_symlink(inodeno_t parent, const char *name, const char *value, struct stat *attr)
@@ -3251,12 +3293,13 @@ int Client::ll_symlink(inodeno_t parent, const char *name, const char *value, st
   path += "/";
   path += name;
   int r = _symlink(value, path.c_str());
-  if (r < 0) return r;
-
-  string dname(name);
-  Inode *in = diri->dir->dentries[dname]->inode;
-  fill_stat(in, attr);
-  return 0;
+  if (r == 0) {
+    string dname(name);
+    Inode *in = diri->dir->dentries[dname]->inode;
+    in->get();
+    fill_stat(in, attr);
+  }
+  return r;
 }
 
 int Client::ll_unlink(inodeno_t ino, const char *name)
@@ -3322,12 +3365,13 @@ int Client::ll_link(inodeno_t ino, inodeno_t newparent, const char *newname, str
   newpath += newname;
 
   int r = _link(path.c_str(), newpath.c_str());
-  if (r < 0) return r;
-
-  string dname(newname);
-  Inode *in = diri->dir->dentries[dname]->inode;
-  fill_stat(in, attr);
-  return 0;
+  if (r == 0) {
+    string dname(newname);
+    Inode *in = diri->dir->dentries[dname]->inode;
+    in->get();
+    fill_stat(in, attr);
+  }
+  return r;
 }
 
 int Client::ll_opendir(inodeno_t ino, void **dirpp)
@@ -3342,6 +3386,7 @@ int Client::ll_opendir(inodeno_t ino, void **dirpp)
   }
   DIR *dir;
   int r = opendir(path.c_str(), &dir);
+  dout(3) << "ll_opendir " << ino << " = " << r << endl;
   if (r < 0) return r;
   *dirpp = (void*)dir;
   return 0;
@@ -3356,10 +3401,31 @@ int Client::ll_open(inodeno_t ino, int flags, Fh **fhp)
   string path;
   in->make_path(path);
 
-  Fh *fh;
-  int r = _open(path.c_str(), flags, 0, &fh);
+  int r = _open(path.c_str(), flags, 0, fhp);
   if (r < 0) return r;
-  dout(3) << "ll_open " << ino << " " << flags << " = " << fh << endl;
+  dout(3) << "ll_open " << ino << " " << flags << " = " << r << " (" << *fhp << ")" << endl;
+  return 0;
+}
+
+int Client::ll_create(inodeno_t parent, const char *name, mode_t mode, int flags, 
+		      struct stat *attr, Fh **fhp)
+{
+  Mutex::Locker lock(client_lock);
+  dout(3) << "ll_create " << parent << " " << name << " " << mode << " " << flags << endl;
+
+  Inode *pin = _ll_get_inode(parent);
+  string path;
+  pin->make_path(path);
+  path += "/";
+  path += name;
+
+  int r = _open(path.c_str(), flags|O_CREAT, mode, fhp);
+  if (r >= 0) {
+    (*fhp)->inode->get();  // this counts as a reference
+    fill_stat((*fhp)->inode, attr);
+  }
+  dout(3) << "ll_create " << parent << " " << name << " " << mode 
+	  << " " << flags << " = " << r << " (" << *fhp << ")" << endl;
   return 0;
 }
 
@@ -3394,18 +3460,17 @@ int Client::ll_release(Fh *fh)
 // layout
 
 
-int Client::describe_layout(int fh, FileLayout *lp)
+int Client::describe_layout(int fd, FileLayout *lp)
 {
-  client_lock.Lock();
-  dout(3) << "op: client->describe_layout(" << fh << ");" << endl;
+  Mutex::Locker lock(client_lock);
 
-  assert(fh_map.count(fh));
-  Fh *f = fh_map[fh];
+  assert(fd_map.count(fd));
+  Fh *f = fd_map[fd];
   Inode *in = f->inode;
 
   *lp = in->inode.layout;
 
-  client_lock.Unlock();
+  dout(3) << "describe_layout(" << fd << ") = 0" << endl;
   return 0;
 }
 
@@ -3430,20 +3495,19 @@ int Client::get_stripe_period(int fd)
   return layout.period();
 }
 
-int Client::enumerate_layout(int fh, list<ObjectExtent>& result,
+int Client::enumerate_layout(int fd, list<ObjectExtent>& result,
 			     off_t length, off_t offset)
 {
-  client_lock.Lock();
-  dout(3) << "op: client->enumerate_layout(" << fh << ", " << length << ", " << offset << ");" << endl;
+  Mutex::Locker lock(client_lock);
 
-  assert(fh_map.count(fh));
-  Fh *f = fh_map[fh];
+  assert(fd_map.count(fd));
+  Fh *f = fd_map[fd];
   Inode *in = f->inode;
 
   // map to a list of extents
   filer->file_to_extents(in->inode, offset, length, result);
 
-  client_lock.Unlock();
+  dout(3) << "enumerate_layout(" << fd << ", " << length << ", " << offset << ") = 0" << endl;
   return 0;
 }
 
diff --git a/branches/sage/mds/client/Client.h b/branches/sage/mds/client/Client.h
index 0337d3e179d1e..70b79613aa345 100644
--- a/branches/sage/mds/client/Client.h
+++ b/branches/sage/mds/client/Client.h
@@ -72,8 +72,6 @@ extern class Logger  *client_logger;
  
 */
 
-typedef int fh_t;
-
 class Dir;
 class Inode;
 
@@ -444,16 +442,16 @@ protected:
 
   // file handles, etc.
   string                 cwd;
-  interval_set<fh_t>     free_fh_set;  // unused fh's
-  hash_map<fh_t, Fh*>    fh_map;
+  interval_set<int> free_fd_set;  // unused fds
+  hash_map<int, Fh*> fd_map;
   
-  fh_t get_fh() {
-    fh_t fh = free_fh_set.start();
-    free_fh_set.erase(fh, 1);
-    return fh;
+  int get_fd() {
+    int fd = free_fd_set.start();
+    free_fd_set.erase(fd, 1);
+    return fd;
   }
-  void put_fh(fh_t fh) {
-    free_fh_set.insert(fh, 1);
+  void put_fd(int fd) {
+    free_fd_set.insert(fd, 1);
   }
 
   void mkabspath(const char *rel, string& abs) {
@@ -637,8 +635,8 @@ private:
     }
   };
 
-  // internal interface
-  //   call these with client_lock held!
+  // some helpers
+  int _do_lstat(const char *path, int mask, Inode **in);
   void _readdir_add_dirent(DirResult *dirp, const string& name, Inode *in);
   void _readdir_add_dirent(DirResult *dirp, const string& name, unsigned char d_type);
   bool _readdir_have_frag(DirResult *dirp);
@@ -646,6 +644,9 @@ private:
   void _readdir_rechoose_frag(DirResult *dirp);
   int _readdir_get_frag(DirResult *dirp);
   void _readdir_fill_dirent(struct dirent *de, DirEntry *entry, off_t);
+
+  // internal interface
+  //   call these with client_lock held!
   int _link(const char *existing, const char *newname);
   int _unlink(const char *path);
   int _rename(const char *from, const char *to);
@@ -653,7 +654,7 @@ private:
   int _rmdir(const char *path);
   int _readlink(const char *path, char *buf, off_t size);
   int _symlink(const char *existing, const char *newname);
-  int _lstat(const char *path, int mask, Inode **in);
+  int _lstat(const char *path, struct stat *stbuf);
   int _chmod(const char *relpath, mode_t mode);
   int _chown(const char *relpath, uid_t uid, gid_t gid);
   int _utime(const char *relpath, utime_t mtime, utime_t atime);
@@ -663,6 +664,7 @@ private:
   int _read(Fh *fh, off_t offset, off_t size, bufferlist *bl);
   int _write(Fh *fh, off_t offset, off_t size, const char *buf);
   int _truncate(const char *file, off_t length);
+  int _ftruncate(Fh *fh, off_t length);
   int _fsync(Fh *fh, bool syncdataonly);
 
 
@@ -716,13 +718,14 @@ public:
   // file ops
   int mknod(const char *path, mode_t mode, dev_t rdev=0);
   int open(const char *path, int flags, mode_t mode=0);
-  int close(fh_t fh);
-  off_t lseek(fh_t fh, off_t offset, int whence);
-  int read(fh_t fh, char *buf, off_t size, off_t offset=-1);
-  int write(fh_t fh, const char *buf, off_t size, off_t offset=-1);
-  int fake_write_size(fh_t fh, off_t size);
+  int close(int fd);
+  off_t lseek(int fd, off_t offset, int whence);
+  int read(int fd, char *buf, off_t size, off_t offset=-1);
+  int write(int fd, const char *buf, off_t size, off_t offset=-1);
+  int fake_write_size(int fd, off_t size);
   int truncate(const char *file, off_t size);
-  int fsync(fh_t fh, bool syncdataonly);
+  int ftruncate(int fd, off_t size);
+  int fsync(int fd, bool syncdataonly);
 
   // hpc lazyio
   int lazyio_propogate(int fd, off_t offset, size_t count);
@@ -737,11 +740,10 @@ public:
 		       off_t length, off_t offset);
 
   // low-level interface
-  int ll_lookup(inodeno_t parent, const char *name, struct stat *attr, 
-		double *attr_timeout, double *entry_timeout);
+  int ll_lookup(inodeno_t parent, const char *name, struct stat *attr);
   void ll_forget(inodeno_t ino, int count);
   Inode *_ll_get_inode(inodeno_t ino);
-  int ll_getattr(inodeno_t ino, struct stat *st, double *attr_timeout);
+  int ll_getattr(inodeno_t ino, struct stat *st);
   int ll_setattr(inodeno_t ino, struct stat *st, int mask);
   int ll_opendir(inodeno_t ino, void **dirpp);
   int ll_readlink(inodeno_t ino, const char **value);
@@ -753,6 +755,7 @@ public:
   int ll_rename(inodeno_t parent, const char *name, inodeno_t newparent, const char *newname);
   int ll_link(inodeno_t ino, inodeno_t newparent, const char *newname, struct stat *attr);
   int ll_open(inodeno_t ino, int flags, Fh **fh);
+  int ll_create(inodeno_t parent, const char *name, mode_t mode, int flags, struct stat *attr, Fh **fh);
   int ll_read(Fh *fh, off_t off, off_t len, bufferlist *bl);
   int ll_write(Fh *fh, off_t off, off_t len, const char *data);
   int ll_release(Fh *fh);
diff --git a/branches/sage/mds/client/fuse.cc b/branches/sage/mds/client/fuse.cc
index 5fbe0414a400a..431025a8d8f13 100644
--- a/branches/sage/mds/client/fuse.cc
+++ b/branches/sage/mds/client/fuse.cc
@@ -143,20 +143,20 @@ static int ceph_open(const char *path, struct fuse_file_info *fi)
 static int ceph_read(const char *path, char *buf, size_t size, off_t offset,
                      struct fuse_file_info *fi)
 {
-  fh_t fh = fi->fh;
-  return client->read(fh, buf, size, offset);
+  int fd = fi->fh;
+  return client->read(fd, buf, size, offset);
 }
 
 static int ceph_write(const char *path, const char *buf, size_t size,
                      off_t offset, struct fuse_file_info *fi)
 {
-  fh_t fh = fi->fh;
-  return client->write(fh, buf, size, offset);
+  int fd = fi->fh;
+  return client->write(fd, buf, size, offset);
 }
 
 static int ceph_flush(const char *path, struct fuse_file_info *fi)
 {
-//fh_t fh = fi->fh;
+  //int fh = fi->fh;
   //return client->flush(fh);
   return 0;
 }
@@ -168,16 +168,16 @@ static int ceph_statfs(const char *path, struct statvfs *stbuf)
 
 static int ceph_release(const char *path, struct fuse_file_info *fi)
 {
-  fh_t fh = fi->fh;
-  int r = client->close(fh);  // close the file
+  int fd = fi->fh;
+  int r = client->close(fd);  // close the file
   return r;
 }
 
 static int ceph_fsync(const char *path, int isdatasync,
                      struct fuse_file_info *fi)
 {
-  fh_t fh = fi->fh;
-  return client->fsync(fh, isdatasync ? true:false);
+  int fd = fi->fh;
+  return client->fsync(fd, isdatasync ? true:false);
 }
 
 
diff --git a/branches/sage/mds/client/fuse_ll.cc b/branches/sage/mds/client/fuse_ll.cc
index bb83b7261888a..869c899ced8b0 100644
--- a/branches/sage/mds/client/fuse_ll.cc
+++ b/branches/sage/mds/client/fuse_ll.cc
@@ -37,7 +37,7 @@ static void ceph_ll_lookup(fuse_req_t req, fuse_ino_t parent, const char *name)
   int stmask;
 
   memset(&fe, 0, sizeof(fe));
-  stmask = client->ll_lookup(parent, name, &fe.attr, &fe.attr_timeout, &fe.entry_timeout);
+  stmask = client->ll_lookup(parent, name, &fe.attr);
   if (stmask >= 0) {
     fe.ino = fe.attr.st_ino;
     fuse_reply_entry(req, &fe);
@@ -59,9 +59,8 @@ static void ceph_ll_getattr(fuse_req_t req, fuse_ino_t ino,
   
   (void) fi;
 
-  double attr_timeout;
-  if (client->ll_getattr(ino, &stbuf, &attr_timeout) == 0) 
-    fuse_reply_attr(req, &stbuf, attr_timeout);
+  if (client->ll_getattr(ino, &stbuf) == 0) 
+    fuse_reply_attr(req, &stbuf, 0);
   else
     fuse_reply_err(req, ENOENT);
 }
@@ -180,13 +179,14 @@ static void ceph_ll_open(fuse_req_t req, fuse_ino_t ino, struct fuse_file_info *
 {
   Fh *fh;
   int r = client->ll_open(ino, fi->flags, &fh);
-  if (r > 0) {
+  if (r == 0) {
     fi->fh = (long)fh;
     fuse_reply_open(req, fi);
   } else {
     fuse_reply_err(req, -r);
   }
 }
+
 static void ceph_ll_read(fuse_req_t req, fuse_ino_t ino, size_t size, off_t off,
 			 struct fuse_file_info *fi)
 {
@@ -283,6 +283,23 @@ static void ceph_ll_releasedir(fuse_req_t req, fuse_ino_t ino,
   fuse_reply_err(req, 0);
 }
 
+static void ceph_ll_create(fuse_req_t req, fuse_ino_t parent, const char *name,
+			   mode_t mode, struct fuse_file_info *fi)
+{
+  struct fuse_entry_param fe;
+  memset(&fe, 0, sizeof(fe));
+  Fh *fh;
+  int r = client->ll_create(parent, name, mode, fi->flags, &fe.attr, &fh);
+  if (r == 0) {
+    fi->fh = (long)fh;
+    fe.ino = fe.attr.st_ino;
+    cout << "ino is " << fe.ino << endl;
+    fuse_reply_create(req, &fe, fi);
+  } else {
+    fuse_reply_err(req, -r);
+  }
+}
+
 static struct fuse_lowlevel_ops ceph_ll_oper = {
  init: 0,
  destroy: 0,
@@ -314,7 +331,7 @@ static struct fuse_lowlevel_ops ceph_ll_oper = {
  listxattr: 0,
  removexattr: 0,
  access: 0,
- create: 0,
+ create: 0, //ceph_ll_create,
  getlk: 0,
  setlk: 0,
  bmap: 0
-- 
2.39.5