From 20e02db29e433b5c163244ac5c8a03d243ec9c08 Mon Sep 17 00:00:00 2001 From: Sebastian Wagner Date: Tue, 23 Feb 2021 11:01:52 +0100 Subject: [PATCH] mgr/rook: OSD create: Fix broken list-comprehension Signed-off-by: Sebastian Wagner --- src/pybind/mgr/rook/rook_cluster.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pybind/mgr/rook/rook_cluster.py b/src/pybind/mgr/rook/rook_cluster.py index 4fd66043036..daf3c8667b7 100644 --- a/src/pybind/mgr/rook/rook_cluster.py +++ b/src/pybind/mgr/rook/rook_cluster.py @@ -592,7 +592,8 @@ class RookCluster(object): if block_devices: if not hasattr(current_node, 'devices'): current_node.devices = ccl.DevicesList() - new_devices = list(set(block_devices) - set([d.name for d in current_node.devices])) + current_device_names = set(d.name for d in current_node.devices) + new_devices = [bd for bd in block_devices if bd.path not in current_device_names] current_node.devices.extend( ccl.DevicesItem(name=n.path) for n in new_devices ) -- 2.47.3