From 2346818aade4f5fd8904e5c11af2b30e3aa13826 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sun, 21 Mar 2021 23:06:00 +0800 Subject: [PATCH] cmake: define BOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT globaly turns out we also need it for compiling librados tests with libboost 1.75, so just define it globally Signed-off-by: Kefu Chai (cherry picked from commit 7ce3ee6f346889d4d87d6424c6a1ad18badd139b) Conflicts: src/CMakeLists.txt src/librbd/CMakeLists.txt: trivial resolution --- src/CMakeLists.txt | 14 ++++++++++++-- src/librbd/CMakeLists.txt | 4 ---- src/rgw/CMakeLists.txt | 4 ---- src/test/rgw/CMakeLists.txt | 4 ---- 4 files changed, 12 insertions(+), 14 deletions(-) diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 2190a9b60a109..6e535dd2c857a 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -23,8 +23,18 @@ set(pkgdatadir ${CMAKE_INSTALL_FULL_DATADIR}) set(datadir ${CEPH_INSTALL_DATADIR}) set(prefix ${CMAKE_INSTALL_PREFIX}) -add_definitions("-DHAVE_CONFIG_H -D__CEPH__ -D_REENTRANT -D_THREAD_SAFE -D__STDC_FORMAT_MACROS") -add_definitions("-D_FILE_OFFSET_BITS=64") +add_definitions( + -DHAVE_CONFIG_H + -D__CEPH__ + -D_REENTRANT + -D_THREAD_SAFE + -D__STDC_FORMAT_MACROS + -D_FILE_OFFSET_BITS=64 + -DBOOST_ASIO_DISABLE_THREAD_KEYWORD_EXTENSION) +if(Boost_VERSION VERSION_GREATER_EQUAL 1.74) + add_definitions(-DBOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT) +endif() + if(LINUX) add_definitions("-D_GNU_SOURCE") endif() diff --git a/src/librbd/CMakeLists.txt b/src/librbd/CMakeLists.txt index ce78d5417b0b8..946f3f5e71ff5 100644 --- a/src/librbd/CMakeLists.txt +++ b/src/librbd/CMakeLists.txt @@ -1,7 +1,3 @@ -if(Boost_VERSION VERSION_GREATER_EQUAL 1.74) - add_definitions(-DBOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT) -endif() - add_library(rbd_types STATIC journal/Types.cc mirroring_watcher/Types.cc diff --git a/src/rgw/CMakeLists.txt b/src/rgw/CMakeLists.txt index 5731627dc7569..c631c7668ad07 100644 --- a/src/rgw/CMakeLists.txt +++ b/src/rgw/CMakeLists.txt @@ -1,7 +1,3 @@ -if(Boost_VERSION VERSION_GREATER_EQUAL 1.74) - add_definitions(-DBOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT) -endif() - add_custom_target(civetweb_h COMMAND ${CMAKE_COMMAND} -E make_directory "${CMAKE_BINARY_DIR}/src/include/civetweb" diff --git a/src/test/rgw/CMakeLists.txt b/src/test/rgw/CMakeLists.txt index 5669c2e3df8b1..c57e56f242ad3 100644 --- a/src/test/rgw/CMakeLists.txt +++ b/src/test/rgw/CMakeLists.txt @@ -1,7 +1,3 @@ -if(Boost_VERSION VERSION_GREATER_EQUAL 1.74) - add_definitions(-DBOOST_ASIO_USE_TS_EXECUTOR_AS_DEFAULT) -endif() - if(WITH_RADOSGW_AMQP_ENDPOINT) # amqp mock library set(amqp_mock_src -- 2.39.5