From 2413da8c854bc46e79ca8d6e84f789f99747c203 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Thu, 24 Nov 2022 13:46:27 +0800 Subject: [PATCH] qa/tasks/cephfs: annotate variable without comment to silence the warning like ``` flake8 run-test: commands[0] | flake8 --select=F,E9 --exclude=venv,.tox ./tasks/cephfs/test_full.py:6:5: F401 'typing.Optional' imported but unused ``` since we've migrated to python3.6 and up, there is no need to be compatible with Python 2 anymore. Signed-off-by: Kefu Chai --- qa/tasks/cephfs/test_full.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/qa/tasks/cephfs/test_full.py b/qa/tasks/cephfs/test_full.py index 962a3d036d1fc..2b3a7d5f95c74 100644 --- a/qa/tasks/cephfs/test_full.py +++ b/qa/tasks/cephfs/test_full.py @@ -2,11 +2,7 @@ import json import logging import os from textwrap import dedent -try: - from typing import Optional -except: - # make it work for python2 - pass +from typing import Optional from teuthology.exceptions import CommandFailedError from tasks.cephfs.fuse_mount import FuseMount from tasks.cephfs.cephfs_test_case import CephFSTestCase @@ -22,7 +18,7 @@ class FullnessTestCase(CephFSTestCase): data_only = False # Subclasses define how many bytes should be written to achieve fullness - pool_capacity = None # type: Optional[int] + pool_capacity: Optional[int] = None fill_mb = None def is_full(self): -- 2.39.5