From 2519c94153e533a81d87e5f0a0ede12753103dca Mon Sep 17 00:00:00 2001
From: Aashish Sharma <Aashish.Sharma1@ibm.com>
Date: Wed, 12 Mar 2025 12:11:14 +0530
Subject: [PATCH] mgr/dashboard: Show notification for multisite sync status in
 case there is some error

Fixes: https://tracker.ceph.com/issues/70413

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
---
 .../rgw-overview-dashboard.component.spec.ts  | 10 +++++++++-
 .../rgw-overview-dashboard.component.ts       | 20 ++++++++++++-------
 2 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.spec.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.spec.ts
index c7aaddcd08fdb..079483ef2003c 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.spec.ts
@@ -12,6 +12,9 @@ import { NO_ERRORS_SCHEMA } from '@angular/core';
 import { RgwRealmService } from '~/app/shared/api/rgw-realm.service';
 import { RgwZoneService } from '~/app/shared/api/rgw-zone.service';
 import { RgwZonegroupService } from '~/app/shared/api/rgw-zonegroup.service';
+import { ToastrModule } from 'ngx-toastr';
+import { SharedModule } from '~/app/shared/shared.module';
+import { ActivatedRoute } from '@angular/router';
 
 describe('RgwOverviewDashboardComponent', () => {
   let component: RgwOverviewDashboardComponent;
@@ -22,6 +25,7 @@ describe('RgwOverviewDashboardComponent', () => {
   let listZonesSpy: jest.SpyInstance;
   let fetchAndTransformBucketsSpy: jest.SpyInstance;
   let totalBucketsAndUsersSpy: jest.SpyInstance;
+  let params: Record<string, any>;
 
   const totalNumObjectsSubject = new BehaviorSubject<number>(290);
   const totalUsedCapacitySubject = new BehaviorSubject<number>(9338880);
@@ -79,9 +83,13 @@ describe('RgwOverviewDashboardComponent', () => {
             averageObjectSize$: averageObjectSizeSubject.asObservable(),
             getTotalBucketsAndUsersLength: jest.fn()
           }
+        },
+        {
+          provide: ActivatedRoute,
+          useValue: { params: { subscribe: (fn: Function) => fn(params) } }
         }
       ],
-      imports: [HttpClientTestingModule]
+      imports: [HttpClientTestingModule, ToastrModule.forRoot(), SharedModule]
     }).compileComponents();
     fixture = TestBed.createComponent(RgwOverviewDashboardComponent);
     component = fixture.componentInstance;
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.ts
index f3a99505e2cee..062f66b113d7c 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-overview-dashboard/rgw-overview-dashboard.component.ts
@@ -17,6 +17,8 @@ import { RgwPromqls as queries } from '~/app/shared/enum/dashboard-promqls.enum'
 import { Icons } from '~/app/shared/enum/icons.enum';
 import { RgwMultisiteService } from '~/app/shared/api/rgw-multisite.service';
 import { catchError, shareReplay, switchMap, tap } from 'rxjs/operators';
+import { NotificationService } from '~/app/shared/services/notification.service';
+import { NotificationType } from '~/app/shared/enum/notification-type.enum';
 
 @Component({
   selector: 'cd-rgw-overview-dashboard',
@@ -60,7 +62,6 @@ export class RgwOverviewDashboardComponent implements OnInit, OnDestroy {
   loading = true;
   multisiteSyncStatus$: Observable<any>;
   subject = new ReplaySubject<any>();
-  syncCardLoading = true;
   fetchDataSub: Subscription;
 
   constructor(
@@ -72,7 +73,8 @@ export class RgwOverviewDashboardComponent implements OnInit, OnDestroy {
     private rgwZoneService: RgwZoneService,
     private rgwBucketService: RgwBucketService,
     private prometheusService: PrometheusService,
-    private rgwMultisiteService: RgwMultisiteService
+    private rgwMultisiteService: RgwMultisiteService,
+    private notificationService: NotificationService
   ) {
     this.permissions = this.authStorageService.getPermissions();
   }
@@ -93,8 +95,8 @@ export class RgwOverviewDashboardComponent implements OnInit, OnDestroy {
         this.averageObjectSize = averageSize;
         this.rgwBucketCount = bucketData.buckets_count;
         this.UserCount = bucketData.users_count;
-        this.getSyncStatus();
       });
+      this.getSyncStatus();
     });
     this.realmSub = this.rgwRealmService.list().subscribe((data: any) => {
       this.rgwRealmCount = data['realms'].length;
@@ -115,16 +117,20 @@ export class RgwOverviewDashboardComponent implements OnInit, OnDestroy {
             this.metadataSyncInfo = data['metadataSyncInfo'];
             if (this.replicaZonesInfo.length === 0) {
               this.showMultisiteCard = false;
-              this.syncCardLoading = false;
               this.loading = false;
             }
             [this.realm, this.zonegroup, this.zone] = data['primaryZoneData'];
           }),
           catchError((err) => {
-            this.showMultisiteCard = false;
-            this.syncCardLoading = false;
-            this.loading = false;
             err.preventDefault();
+            this.loading = false;
+            this.showMultisiteCard = false;
+            const errorMessage = $localize`Unable to fetch sync status`;
+            this.notificationService.show(
+              NotificationType.error,
+              errorMessage,
+              err.error.detail || err.error.message
+            );
             return of(true);
           })
         )
-- 
2.39.5