From 28cf5ac8b0025a1a3a947a934f628d3e627f3e20 Mon Sep 17 00:00:00 2001 From: Jos Collin Date: Sat, 24 Jun 2017 20:59:43 +0530 Subject: [PATCH] test: Division by zero in Legacy::encode_n() Fixes the Coverity Scan Report: CID 1411820 (#1 of 1): Division or modulo by zero (DIVIDE_BY_ZERO) 9. divide_by_zero: In expression bl.length() * i / sum, division by expression sum which may be zero has undefined behavior. Signed-off-by: Jos Collin --- src/test/test_denc.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test_denc.cc b/src/test/test_denc.cc index fea7e987eebc2..6a7c4a2defee0 100644 --- a/src/test/test_denc.cc +++ b/src/test/test_denc.cc @@ -613,6 +613,7 @@ bufferlist Legacy::encode_n(unsigned n, const vector& segments) { auto p = bl.begin(); auto sum = std::accumulate(segments.begin(), segments.end(), 0u); + assert(sum != 0u); for (auto i : segments) { buffer::ptr seg; p.copy_deep(bl.length() * i / sum, seg); -- 2.39.5