From 2931de473cc18a8f866fa0a08805d50ed0f4079b Mon Sep 17 00:00:00 2001 From: Eric Whitney Date: Wed, 10 Jan 2018 16:19:05 -0500 Subject: [PATCH] common/rc: ext4 doesn't support O_DIRECT with data journaling Modify _require_odirect() to skip O_DIRECT tests if the ext4 mount option data=journal has been applied. Because ext4 disables its O_DIRECT support when in data journaling mode, no significant value is obtained by running these tests and they consume a significant amount of run time. Additionally, this change eliminates the need to triage false negative O_DIRECT test results caused by test problems, as has occurred from time to time. Signed-off-by: Eric Whitney Reviewed-by: Theodore Ts'o Signed-off-by: Eryu Guan --- common/rc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/rc b/common/rc index d47c1dbe..fa3b2150 100644 --- a/common/rc +++ b/common/rc @@ -2150,6 +2150,8 @@ _require_odirect() if [ $FSTYP = "ext4" ] ; then if echo "$MOUNT_OPTIONS" | grep -q "test_dummy_encryption"; then _notrun "ext4 encryption doesn't support O_DIRECT" + elif echo "$MOUNT_OPTIONS" | grep -q "data=journal"; then + _notrun "ext4 data journaling doesn't support O_DIRECT" fi fi testfile=$TEST_DIR/$$.direct -- 2.47.3