From 2a5a50f3bace6b853fe2feff85a641ade91825e1 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Wed, 20 Jan 2021 01:26:06 +0800 Subject: [PATCH] pybind/mgr/cephadm/serve: add assert to appease mypy Signed-off-by: Kefu Chai --- src/pybind/mgr/cephadm/serve.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/pybind/mgr/cephadm/serve.py b/src/pybind/mgr/cephadm/serve.py index 8a4e4601e74..419398edd5d 100644 --- a/src/pybind/mgr/cephadm/serve.py +++ b/src/pybind/mgr/cephadm/serve.py @@ -401,13 +401,17 @@ class CephadmServe: daemon_detail = [] # type: List[str] for item in ls: host = item.get('hostname') + assert isinstance(host, str) daemons = item.get('services') # misnomer! + assert isinstance(daemons, list) missing_names = [] for s in daemons: - name = '%s.%s' % (s.get('type'), s.get('id')) + daemon_id = s.get('id') + assert daemon_id + name = '%s.%s' % (s.get('type'), daemon_id) if s.get('type') == 'rbd-mirror': metadata = self.mgr.get_metadata( - "rbd-mirror", s.get('id')) + "rbd-mirror", daemon_id) try: name = '%s.%s' % (s.get('type'), metadata['id']) except (KeyError, TypeError): -- 2.39.5