From 2ae36e54f1cceb8ed28e237f7b6b430b652efd1f Mon Sep 17 00:00:00 2001 From: amitkuma Date: Wed, 13 Sep 2017 21:34:59 +0530 Subject: [PATCH] librbd: Initialization of class member variables Fixes the coverity issues: ** 1402627 Uninitialized scalar field CID 1402627 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member promotion_state is not initialized in this constructor nor in any functions that it calls. ** 1402630 Uninitialized scalar field CID 1402630 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member m_promotion_state is not initialized in this constructor nor in any functions that it calls. ** 1402631 Uninitialized scalar field CID 1402631 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member m_promotion_state is not initialized in this constructor nor in any functions that it calls. ** 1402632 Uninitialized scalar field CID 1402632 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR) 2. uninit_member: Non-static class member tag_tid is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Amit Kumar --- src/librbd/Journal.cc | 2 +- src/librbd/api/Mirror.cc | 2 +- src/librbd/mirror/DemoteRequest.h | 2 +- src/librbd/mirror/PromoteRequest.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/librbd/Journal.cc b/src/librbd/Journal.cc index 37e84d7d421d..c7b5e11f6929 100644 --- a/src/librbd/Journal.cc +++ b/src/librbd/Journal.cc @@ -104,7 +104,7 @@ struct C_GetTagOwner : public Context { Journaler journaler; cls::journal::Client client; journal::ImageClientMeta client_meta; - uint64_t tag_tid; + uint64_t tag_tid = 0; journal::TagData tag_data; C_GetTagOwner(librados::IoCtx &io_ctx, const std::string &image_id, diff --git a/src/librbd/api/Mirror.cc b/src/librbd/api/Mirror.cc index 25ffea03e8c0..560cfde5f263 100644 --- a/src/librbd/api/Mirror.cc +++ b/src/librbd/api/Mirror.cc @@ -82,7 +82,7 @@ struct C_ImageGetInfo : public Context { Context *on_finish; cls::rbd::MirrorImage mirror_image; - mirror::PromotionState promotion_state; + mirror::PromotionState promotion_state = mirror::PROMOTION_STATE_PRIMARY; C_ImageGetInfo(mirror_image_info_t *mirror_image_info, Context *on_finish) : mirror_image_info(mirror_image_info), on_finish(on_finish) { diff --git a/src/librbd/mirror/DemoteRequest.h b/src/librbd/mirror/DemoteRequest.h index a4f6f0c09646..7dc0585e056c 100644 --- a/src/librbd/mirror/DemoteRequest.h +++ b/src/librbd/mirror/DemoteRequest.h @@ -59,7 +59,7 @@ private: bool m_blocked_requests = false; cls::rbd::MirrorImage m_mirror_image; - PromotionState m_promotion_state; + PromotionState m_promotion_state = PROMOTION_STATE_PRIMARY; void get_info(); void handle_get_info(int r); diff --git a/src/librbd/mirror/PromoteRequest.h b/src/librbd/mirror/PromoteRequest.h index 185dc22b0ed5..17609c5ff8ca 100644 --- a/src/librbd/mirror/PromoteRequest.h +++ b/src/librbd/mirror/PromoteRequest.h @@ -55,7 +55,7 @@ private: Context *m_on_finish; cls::rbd::MirrorImage m_mirror_image; - PromotionState m_promotion_state; + PromotionState m_promotion_state = PROMOTION_STATE_PRIMARY; void get_info(); void handle_get_info(int r); -- 2.47.3