From 2afd9803461acf93544c0174583e8682d4f89002 Mon Sep 17 00:00:00 2001 From: Casey Bodley Date: Sun, 11 Sep 2022 18:13:52 -0400 Subject: [PATCH] rgw: rados service shuts down rados client on shutdown() if we leave the rados client running, it will keep delivering AioCompletions while we're shutting other things down this resolves a valgrind use-after-free where rgw::notify::Manager gets completions after its destruction Signed-off-by: Casey Bodley --- src/rgw/services/svc_rados.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/src/rgw/services/svc_rados.cc b/src/rgw/services/svc_rados.cc index 1617a2ec6c6..388f0b05cfc 100644 --- a/src/rgw/services/svc_rados.cc +++ b/src/rgw/services/svc_rados.cc @@ -45,6 +45,7 @@ void RGWSI_RADOS::shutdown() if (async_processor) { async_processor->stop(); } + rados.shutdown(); } void RGWSI_RADOS::stop_processor() -- 2.39.5