From 2e3f4689a13cbb59435bff022bba236f2a35f3b8 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sat, 24 Jul 2021 21:19:26 +0800 Subject: [PATCH] kv/RocksDBStore: always initialize local variable MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit silences following warning from GCC: ../src/kv/RocksDBStore.cc:386:7: warning: ‘r’ may be used uninitialized in this function [-Wmaybe-uninitialized] 386 | if (r < 0) { | ^~ Signed-off-by: Kefu Chai --- src/kv/RocksDBStore.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/kv/RocksDBStore.cc b/src/kv/RocksDBStore.cc index 05ad8844cb017..b826bb959d8f0 100644 --- a/src/kv/RocksDBStore.cc +++ b/src/kv/RocksDBStore.cc @@ -363,7 +363,6 @@ int RocksDBStore::ParseOptionsFromStringStatic( { // keep aligned with func tryInterpret const set need_interp_keys = {"compaction_threads", "flusher_threads", "compact_on_mount", "disableWAL"}; - int r; rocksdb::Status status; std::unordered_map str_map; status = StringToMap(opt_str, &str_map); @@ -377,6 +376,7 @@ int RocksDBStore::ParseOptionsFromStringStatic( string this_opt = it->first + "=" + it->second; rocksdb::Status status = rocksdb::GetOptionsFromString(opt, this_opt, &opt); + int r = 0; if (!status.ok()) { if (interp != nullptr) { r = interp(it->first, it->second, opt); -- 2.39.5