From 2ed00c0328ffb250aa1dad616d4e4586747ea288 Mon Sep 17 00:00:00 2001 From: Kefu Chai Date: Sat, 11 Jan 2020 16:26:54 +0800 Subject: [PATCH] crimson: move() explicitly to avoid copy to silence following warnings from clang 9.0.1: src/crimson/osd/heartbeat.cc:143:14: warning: local variable 'extras' will be copied despite being returned by name [-Wreturn-std-move] return extras; ^~~~~~ ../src/crimson/osd/heartbeat.cc:143:14: note: call 'std::move' explicitly to avoid copying return extras; ^~~~~~ std::move(extras) Signed-off-by: Kefu Chai --- src/crimson/osd/heartbeat.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/crimson/osd/heartbeat.cc b/src/crimson/osd/heartbeat.cc index 139e684c092..2fdfe1abee5 100644 --- a/src/crimson/osd/heartbeat.cc +++ b/src/crimson/osd/heartbeat.cc @@ -139,7 +139,7 @@ seastar::future Heartbeat::remove_down_peers() if (extra >= 0) { extras.push_back(extra); } - return extras; + return std::move(extras); }); } -- 2.47.3