From 2ee29047ca564f04f1d27dc0aee09dcf42ab9c5a Mon Sep 17 00:00:00 2001 From: cuiming_yewu Date: Fri, 22 Sep 2023 10:45:30 +0800 Subject: [PATCH] kv:resolve three complication warnings Resolve three warning issues in the derived classes overriding base class virtual functions with mismatched parameter lists at lines 69, 72, and 74 in src/kv/rocksdb_cache/ShardedCache.h. with ../src/kv/rocksdb_cache/ShardedCache.h:74:16: warning: by 'virtual bool rocksdb_cache::ShardedCache::Release(rocksdb::Cache::Handle*, bool)' [-Woverloaded-virtual] virtual bool Release(rocksdb::Cache::Handle* handle, bool force_erase = false) override; ^~~~~~~ ../src/kv/rocksdb_cache/ShardedCache.h:72:35: warning: by 'virtual rocksdb::Cache::Handle* rocksdb_cache::ShardedCache::Lookup(const rocksdb::Slice&, rocksdb::Statistics*)' [-Woverloaded-virtual] virtual rocksdb::Cache::Handle* Lookup(const rocksdb::Slice& key, rocksdb::Statistics* stats) override; ^~~~~~ ../src/kv/rocksdb_cache/ShardedCache.h:69:27: warning: by 'virtual rocksdb::Status rocksdb_cache::ShardedCache::Insert(const rocksdb::Slice&, void*, size_t, rocksdb::Cache::DeleterFn, rocksdb::Cache::Handle**, rocksdb::Cache::Priority)' [-Woverloaded-virtual] virtual rocksdb::Status Insert(const rocksdb::Slice& key, void* value, size_t charge, ^~~~~~ Signed-off-by: cuiming --- src/kv/rocksdb_cache/ShardedCache.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/kv/rocksdb_cache/ShardedCache.h b/src/kv/rocksdb_cache/ShardedCache.h index ef4b10d8f273..63a56c4577eb 100644 --- a/src/kv/rocksdb_cache/ShardedCache.h +++ b/src/kv/rocksdb_cache/ShardedCache.h @@ -66,11 +66,14 @@ class ShardedCache : public rocksdb::Cache, public PriorityCache::PriCache { virtual ~ShardedCache() = default; // rocksdb::Cache virtual const char* Name() const override = 0; + using rocksdb::Cache::Insert; virtual rocksdb::Status Insert(const rocksdb::Slice& key, void* value, size_t charge, DeleterFn, rocksdb::Cache::Handle** handle, Priority priority) override; + using rocksdb::Cache::Lookup; virtual rocksdb::Cache::Handle* Lookup(const rocksdb::Slice& key, rocksdb::Statistics* stats) override; virtual bool Ref(rocksdb::Cache::Handle* handle) override; + using rocksdb::Cache::Release; virtual bool Release(rocksdb::Cache::Handle* handle, bool force_erase = false) override; virtual void* Value(Handle* handle) override = 0; virtual void Erase(const rocksdb::Slice& key) override; -- 2.47.3