From 2f11631f3144f2cc0e04d718e40e716540c8af19 Mon Sep 17 00:00:00 2001 From: Sage Weil Date: Sat, 16 Aug 2014 12:42:33 -0700 Subject: [PATCH] os/FileStore: fix mount/remount force_sync race Consider: - mount - sync_entry is doing some work - umount - set force_sync = true - set done = true - sync_entry exits (due to done) - ..but does not set force_sync = false - mount - journal replay starts - sync_entry sees force_sync and does a commit while op_seq == 0 ...crash... Fixes: #9144 Backport: firefly, dumpling Signed-off-by: Sage Weil (cherry picked from commit dd11042f969b94f7a461d02e1475794031c79f61) Conflicts: src/os/FileStore.cc --- src/os/FileStore.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/os/FileStore.cc b/src/os/FileStore.cc index 38b7f03cf02..1a3f9578876 100644 --- a/src/os/FileStore.cc +++ b/src/os/FileStore.cc @@ -1558,6 +1558,8 @@ int FileStore::umount() backend = generic_backend; } + force_sync = false; + object_map.reset(); { -- 2.47.3