From 2f136d62bf4527e03ebae9298bdd4fd743d8699c Mon Sep 17 00:00:00 2001 From: Eric Sandeen Date: Wed, 9 Jan 2013 10:17:59 -0600 Subject: [PATCH] xfstests: test EROFS vs. EEXIST when creating on an RO filesystem TBH, I don't know if this is posix-specified, but I found out the hard way that when trying to re-create existing files on a readonly filesystem, some apps expect/handle EEXIST, but fail on EROFS. This will test mkdir, mknod, and symlinks for that behavior. Signed-off-by: Eric Sandeen Reviewed-by: Dave Chinner Signed-off-by: Ben Myers --- 294 | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 294.out | 5 ++++ group | 1 + 3 files changed, 79 insertions(+) create mode 100644 294 create mode 100644 294.out diff --git a/294 b/294 new file mode 100644 index 00000000..192809cd --- /dev/null +++ b/294 @@ -0,0 +1,73 @@ +#! /bin/bash +# FS QA Test No. 294 +# +# Tests for EEXIST (not EROFS) for inode creations, if +# we ask to create an already-existing entity on an RO filesystem +# +#----------------------------------------------------------------------- +# Copyright (c) 2012 Red Hat, Inc. All Rights Reserved. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it would be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write the Free Software Foundation, +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +#----------------------------------------------------------------------- +# +# creator +owner=sandeen@redhat.com + +seq=`basename $0` +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common.rc +. ./common.filter + +# real QA test starts here + +# Modify as appropriate. +_supported_fs generic +_supported_os Linux +_require_scratch + +THIS_TEST_DIR=$SCRATCH_MNT/$seq.test + +_create_files() +{ + mknod $THIS_TEST_DIR/testnode c 1 3 + mkdir $THIS_TEST_DIR/testdir + touch $THIS_TEST_DIR/testtarget + ln -s $THIS_TEST_DIR/testtarget $THIS_TEST_DIR/testlink 2>&1 | _filter_ln +} + +_scratch_mount + +rm -rf $THIS_TEST_DIR +mkdir $THIS_TEST_DIR || _fail "Could not create dir for test" + +_create_files 2>&1 | _filter_scratch +_scratch_mount -o remount,ro || _fail "Could not remount scratch readonly" +_create_files 2>&1 | _filter_scratch + +# success, all done +status=0 +exit diff --git a/294.out b/294.out new file mode 100644 index 00000000..027d9fca --- /dev/null +++ b/294.out @@ -0,0 +1,5 @@ +QA output created by 294 +mknod: `SCRATCH_MNT/294.test/testnode': File exists +mkdir: cannot create directory `SCRATCH_MNT/294.test/testdir': File exists +touch: cannot touch `SCRATCH_MNT/294.test/testtarget': Read-only file system +ln: creating symbolic link `SCRATCH_MNT/294.test/testlink': File exists diff --git a/group b/group index 1fdae317..505bc7f5 100644 --- a/group +++ b/group @@ -412,3 +412,4 @@ deprecated 291 repair 292 auto mkfs quick 293 auto quick +294 auto quick -- 2.39.5