From 2f4197e31e22d65faf7a83743db0f689af62ad54 Mon Sep 17 00:00:00 2001 From: Aishwarya Mathuria Date: Mon, 3 Feb 2025 12:15:34 +0000 Subject: [PATCH] mon/OSDMonitor: Remove check for FLAG_NOPGCHANGE for crimson pools With PG Splitting introduced, we can remove the check that previously stopped changes in pg_num for crimson pools. Note: `nopgchange` is set to true by default with Crimson pools, for pg_num changes to actually take place we should also set `nopgchange` to false. Currently, this is used for (PG splitting) testing only. Once PG merging is in place as well, we could revert `nopgchange` to be false by default in Crimson. Signed-off-by: Aishwarya Mathuria --- src/mon/OSDMonitor.cc | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/mon/OSDMonitor.cc b/src/mon/OSDMonitor.cc index 6c4a2b5747e..bc23cdff909 100644 --- a/src/mon/OSDMonitor.cc +++ b/src/mon/OSDMonitor.cc @@ -8777,10 +8777,6 @@ int OSDMonitor::prepare_command_pool_set(const cmdmap_t& cmdmap, if (val == "true" || (interr.empty() && n == 1)) { p.set_flag(flag); } else if (val == "false" || (interr.empty() && n == 0)) { - if (flag == pg_pool_t::FLAG_NOPGCHANGE && p.is_crimson()) { - ss << "cannot clear FLAG_NOPGCHANGE on a crimson pool"; - return -EINVAL; - } p.unset_flag(flag); } else { ss << "expecting value 'true', 'false', '0', or '1'"; -- 2.39.5