From 3014069a7f01c900734e798ad7db8811e5b8f4c9 Mon Sep 17 00:00:00 2001
From: Afreen Misbah <afreen23.git@gmail.com>
Date: Tue, 27 Aug 2024 09:55:49 +0530
Subject: [PATCH] mgr/dashboard: Update nvmeof microcopies

- As per the review from the stakeholders , updating the microcopies in nvmeof.
- in task service file changed casing of `Service` to align with rest.

Fixes https://tracker.ceph.com/issues/67728

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
(cherry picked from commit 5d1ee140d0514348faa1db323a18c69fcb8950e6)
---
 .../ceph/block/nvmeof-gateway/nvmeof-gateway.component.html    | 3 +--
 .../nvmeof-initiators-list.component.html                      | 3 ++-
 .../nvmeof-listeners-list/nvmeof-listeners-list.component.html | 2 +-
 .../nvmeof-namespaces-form.component.html                      | 2 +-
 .../block/nvmeof-subsystems/nvmeof-subsystems.component.html   | 2 +-
 .../cluster/services/service-form/service-form.component.html  | 2 +-
 .../frontend/src/app/shared/services/task-message.service.ts   | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-gateway/nvmeof-gateway.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-gateway/nvmeof-gateway.component.html
index 18a4000e14d..c466c8674cc 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-gateway/nvmeof-gateway.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-gateway/nvmeof-gateway.component.html
@@ -3,8 +3,7 @@
 <legend i18n>
   Gateways
   <cd-help-text>
-    The NVMe-oF gateway integrates Ceph with the NVMe over TCP (NVMe/TCP) protocol to provide an NVMe/TCP target that exports RADOS Block Device (RBD) images.
-  </cd-help-text>
+    Ceph NVMe-oF gateways provide Ceph Block Device storage through NVMe/TCP. For VMware clients the NVMe/TCP volumes display as  VMFS Datastores. For Linux clients the NVMe/TCP volumes display as as block devices.</cd-help-text>
 </legend>
 <div>
   <cd-table [data]="gateways"
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-initiators-list/nvmeof-initiators-list.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-initiators-list/nvmeof-initiators-list.component.html
index 29ebbe645d1..bdbe7320cfa 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-initiators-list/nvmeof-initiators-list.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-initiators-list/nvmeof-initiators-list.component.html
@@ -1,6 +1,7 @@
 <legend>
   <cd-help-text>
-      The client that connects to the NVMe-oF target to access NVMe storage.
+    An initiator (or host) is the client that connects to the NVMe-oF target to access NVMe storage.
+    The NVMe/TCP protocol allows initiators, to send NVMe-oF commands to storage devices, which are known as targets.
   </cd-help-text>
 </legend>
 <cd-table [data]="initiators"
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-listeners-list/nvmeof-listeners-list.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-listeners-list/nvmeof-listeners-list.component.html
index da001554120..1a24ddfd28c 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-listeners-list/nvmeof-listeners-list.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-listeners-list/nvmeof-listeners-list.component.html
@@ -1,6 +1,6 @@
 <legend>
   <cd-help-text>
-    A listener defines the IP port on the gateway that is to process NVMe/TCP commands and I/O operations.
+    A listener defines the IP address and port on the gateway that is used to process NVMe/TCP admin and I/O commands to a subsystem.
   </cd-help-text>
 </legend>
 <cd-table [data]="listeners"
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.html
index 72576b7e642..87e474de757 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-namespaces-form/nvmeof-namespaces-form.component.html
@@ -39,7 +39,7 @@
                       [value]="pool.pool_name">{{ pool.pool_name }}</option>
             </select>
             <cd-help-text i18n>
-              A RBD application-enabled pool where the image will be created.
+              An RBD application-enabled pool where the image will be created.
             </cd-help-text>
             <span class="invalid-feedback"
                   *ngIf="nsForm.showError('pool', formDir, 'required')"
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-subsystems/nvmeof-subsystems.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-subsystems/nvmeof-subsystems.component.html
index 4dc04437330..038ac9d3c35 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-subsystems/nvmeof-subsystems.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/block/nvmeof-subsystems/nvmeof-subsystems.component.html
@@ -2,7 +2,7 @@
 <legend i18n>
   Subsystems
   <cd-help-text>
-    A subsystem presents a collection of controllers which are used to access namespaces.
+    A subsystem provides access control to which hosts can access the namespaces within the subsystem.
   </cd-help-text>
 </legend>
 <cd-table [data]="subsystems"
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.html
index bd8b12564eb..34ea0fbac42 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.html
+++ b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.html
@@ -97,7 +97,7 @@
                       [value]="pool.pool_name">{{ pool.pool_name }}</option>
             </select>
             <cd-help-text i18n>
-              A pool in which the gateway configuration can be managed.
+              An RBD application-enabled pool in which the gateway configuration can be managed.
             </cd-help-text>
             <span class="invalid-feedback"
                   *ngIf="serviceForm.showError('pool', frm, 'required')"
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/services/task-message.service.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/services/task-message.service.ts
index c4f57286a3a..42fc617b12c 100644
--- a/src/pybind/mgr/dashboard/frontend/src/app/shared/services/task-message.service.ts
+++ b/src/pybind/mgr/dashboard/frontend/src/app/shared/services/task-message.service.ts
@@ -534,7 +534,7 @@ export class TaskMessageService {
   }
 
   service(metadata: any) {
-    return $localize`Service '${metadata.service_name}'`;
+    return $localize`service '${metadata.service_name}'`;
   }
 
   crudMessage(metadata: any) {
-- 
2.39.5