From 30a74ce343caec2a433cb532ba697fe7013ed05c Mon Sep 17 00:00:00 2001 From: John Spray Date: Mon, 11 Sep 2017 09:12:25 -0400 Subject: [PATCH] ceph.in: use PRIO_INTERESTING as daemonperf threshold Using PRIO_USEFUL as the threshold for what goes into time series databases. I'm claiming that we have more "useful" counters than fit on the screen, so daemonperf's "a screen's worth" threshold should be at the "interesting" level. Signed-off-by: John Spray --- src/ceph.in | 2 +- src/common/perf_counters.h | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/ceph.in b/src/ceph.in index e96eca56820..daec2993764 100755 --- a/src/ceph.in +++ b/src/ceph.in @@ -48,7 +48,7 @@ PRIO_USEFUL = 5 PRIO_UNINTERESTING = 2 PRIO_DEBUGONLY = 0 -PRIO_DEFAULT = PRIO_USEFUL +PRIO_DEFAULT = PRIO_INTERESTING # Make life easier on developers: # If our parent dir contains CMakeCache.txt and bin/init-ceph, diff --git a/src/common/perf_counters.h b/src/common/perf_counters.h index ec81de4f359..27fc5f071ae 100644 --- a/src/common/perf_counters.h +++ b/src/common/perf_counters.h @@ -279,9 +279,14 @@ public: // prio values: higher is better, and higher values get included in // 'ceph daemonperf' (and similar) results. + // Use of priorities enables us to add large numbers of counters + // internally without necessarily overwhelming consumers. enum { PRIO_CRITICAL = 10, + // 'interesting' is the default threshold for `daemonperf` output PRIO_INTERESTING = 8, + // `useful` is the default threshold for transmission to ceph-mgr + // and inclusion in prometheus/influxdb plugin output PRIO_USEFUL = 5, PRIO_UNINTERESTING = 2, PRIO_DEBUGONLY = 0, -- 2.47.3