From 30cab5c0c62e20304a3c6b40f8c0bd471a2aa302 Mon Sep 17 00:00:00 2001 From: Ilya Dryomov Date: Fri, 21 Mar 2025 14:49:44 +0100 Subject: [PATCH] librbd: don't use public API flags in Group::snap_create() Use internal flags obtained from snap_create_flags_api_to_internal() instead -- internal_flags variable was assigned but not used. Signed-off-by: Ilya Dryomov (cherry picked from commit f33bb0802e45966e794ec60454578df80dac41f6) --- src/librbd/api/Group.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/librbd/api/Group.cc b/src/librbd/api/Group.cc index da0dba4a6405c..9ce7e033ef81e 100644 --- a/src/librbd/api/Group.cc +++ b/src/librbd/api/Group.cc @@ -885,8 +885,6 @@ int Group::snap_create(librados::IoCtx& group_ioctx, if (r < 0) { return r; } - internal_flags &= ~(SNAP_CREATE_FLAG_SKIP_NOTIFY_QUIESCE | - SNAP_CREATE_FLAG_IGNORE_NOTIFY_QUIESCE_ERROR); r = cls_client::dir_get_id(&group_ioctx, RBD_GROUP_DIRECTORY, group_name, &group_id); @@ -975,10 +973,11 @@ int Group::snap_create(librados::IoCtx& group_ioctx, goto remove_record; } - if ((flags & RBD_SNAP_CREATE_SKIP_QUIESCE) == 0) { + if ((internal_flags & SNAP_CREATE_FLAG_SKIP_NOTIFY_QUIESCE) == 0) { ldout(cct, 20) << "Sending quiesce notification" << dendl; ret_code = notify_quiesce(ictxs, prog_ctx, &quiesce_requests); - if (ret_code != 0 && (flags & RBD_SNAP_CREATE_IGNORE_QUIESCE_ERROR) == 0) { + if (ret_code != 0 && + (internal_flags & SNAP_CREATE_FLAG_IGNORE_NOTIFY_QUIESCE_ERROR) == 0) { goto remove_record; } } -- 2.39.5