From 3125eb20b9dbd0df7bb030691c6103374e9f6457 Mon Sep 17 00:00:00 2001 From: Rishabh Dave Date: Tue, 9 Aug 2022 14:24:37 +0530 Subject: [PATCH] qa/vstart_runner: don't pass sudo for ceph-fuse command Since we pass option "--client_die_on_failed_dentry_invalidate=false" to ceph-fuse commands issued by vstart_runner.py, passing "sudo" in ceph-fuse command arguments is unnecessary. This removes the error message (see below) from vstart_runner.py output that informs the users that "sudo" was removed from command arguments. This message is redundant and even misleading as the option above is passed to ceph-fuse command. This will have no functional changes on ceph-fuse mount command issued by vstart_runner.py since FuseMount._run_mount_cmd() did not pass "omit_sudo=False" (and since default value for omit_sudo in method LocalRemote.run() of vstart_runner.py is true, vstart_runner.py removes "sudo" from ceph-fuse command arguments of before execution). The error message - DEBUG:__main__:"sudo" was omitted from the following cmd args before execution and logging using function overriding; check vstart_runner.py for more details. DEBUG:__main__:> sudo ./bin/ceph-fuse /tmp/tmp8o4s_6md/mnt.0 --id 0 --client_mountpoint=/ --client_die_on_failed_dentry_invalidate=false Signed-off-by: Rishabh Dave --- qa/tasks/vstart_runner.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/qa/tasks/vstart_runner.py b/qa/tasks/vstart_runner.py index 5ad608cebcf..caf7a7fe3f7 100644 --- a/qa/tasks/vstart_runner.py +++ b/qa/tasks/vstart_runner.py @@ -734,6 +734,11 @@ class LocalFuseMount(LocalCephFSMount, FuseMount): if os.getuid() != 0: mount_cmd += ['--client_die_on_failed_dentry_invalidate=false'] + # XXX: Passing ceph-fuse option above makes using sudo command + # redunant. Plus, we prefer that vstart_runner.py doesn't use sudo + # command as far as possbile. + mount_cmd.remove('sudo') + return mount_cmd @property -- 2.39.5