From 31b692f4e38e94d3e690921418f8eeebc2b48212 Mon Sep 17 00:00:00 2001 From: Aashish Sharma Date: Wed, 17 May 2023 16:47:15 +0530 Subject: [PATCH] mgr/dashboard: Rename Cluster > Monitoring to Alerts and change Cluster>Users to Cluster>Ceph Users Fixes: https://tracker.ceph.com/issues/61213 Signed-off-by: Aashish Sharma --- .../cypress/integration/cluster/users.e2e-spec.ts | 4 ++-- .../frontend/cypress/integration/ui/navigation.po.ts | 4 ++-- .../dashboard/frontend/src/app/app-routing.module.ts | 10 +++++----- .../navigation/navigation/navigation.component.html | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/pybind/mgr/dashboard/frontend/cypress/integration/cluster/users.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/cypress/integration/cluster/users.e2e-spec.ts index 8374e7c7500fd..87acda97fd83c 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/integration/cluster/users.e2e-spec.ts +++ b/src/pybind/mgr/dashboard/frontend/cypress/integration/cluster/users.e2e-spec.ts @@ -1,6 +1,6 @@ import { UsersPageHelper } from './users.po'; -describe('Cluster Users', () => { +describe('Cluster Ceph Users', () => { const users = new UsersPageHelper(); beforeEach(() => { @@ -11,7 +11,7 @@ describe('Cluster Users', () => { describe('breadcrumb and tab tests', () => { it('should open and show breadcrumb', () => { - users.expectBreadcrumbText('Users'); + users.expectBreadcrumbText('Ceph Users'); }); }); diff --git a/src/pybind/mgr/dashboard/frontend/cypress/integration/ui/navigation.po.ts b/src/pybind/mgr/dashboard/frontend/cypress/integration/ui/navigation.po.ts index 3713bd772c1a5..3bad05559907f 100644 --- a/src/pybind/mgr/dashboard/frontend/cypress/integration/ui/navigation.po.ts +++ b/src/pybind/mgr/dashboard/frontend/cypress/integration/ui/navigation.po.ts @@ -27,9 +27,9 @@ export class NavigationPageHelper extends PageHelper { { menu: 'Configuration', component: 'cd-configuration' }, { menu: 'CRUSH map', component: 'cd-crushmap' }, { menu: 'Manager Modules', component: 'cd-mgr-module-list' }, - { menu: 'Users', component: 'cd-crud-table' }, + { menu: 'Ceph Users', component: 'cd-crud-table' }, { menu: 'Logs', component: 'cd-logs' }, - { menu: 'Monitoring', component: 'cd-prometheus-tabs' } + { menu: 'Alerts', component: 'cd-prometheus-tabs' } ] }, { menu: 'Pools', component: 'cd-pool-list' }, diff --git a/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts b/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts index 3d404b6f04360..640e838909f46 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts +++ b/src/pybind/mgr/dashboard/frontend/src/app/app-routing.module.ts @@ -121,7 +121,7 @@ const routes: Routes = [ path: 'ceph-users', component: CRUDTableComponent, data: { - breadcrumbs: 'Cluster/Users', + breadcrumbs: 'Cluster/Ceph Users', resource: 'api.cluster.user@1.0' } }, @@ -129,7 +129,7 @@ const routes: Routes = [ path: 'cluster/user/create', component: CrudFormComponent, data: { - breadcrumbs: 'Cluster/Users', + breadcrumbs: 'Cluster/Ceph Users/Create', resource: 'api.cluster.user@1.0' } }, @@ -137,7 +137,7 @@ const routes: Routes = [ path: 'cluster/user/import', component: CrudFormComponent, data: { - breadcrumbs: 'Cluster/Users', + breadcrumbs: 'Cluster/Ceph Users/Import', resource: 'api.cluster.user@1.0' } }, @@ -145,7 +145,7 @@ const routes: Routes = [ path: 'cluster/user/edit', component: CrudFormComponent, data: { - breadcrumbs: 'Cluster/Users', + breadcrumbs: 'Cluster/Ceph Users/Edit', resource: 'api.cluster.user@1.0' } }, @@ -237,7 +237,7 @@ const routes: Routes = [ }, { path: 'monitoring', - data: { breadcrumbs: 'Cluster/Monitoring' }, + data: { breadcrumbs: 'Cluster/Alerts' }, children: [ { path: '', redirectTo: 'active-alerts', pathMatch: 'full' }, { diff --git a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html index 0ea5e8dc3e388..159f249d5d9e7 100644 --- a/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html +++ b/src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html @@ -155,7 +155,7 @@ class="tc_submenuitem tc_submenuitem_users" *ngIf="permissions.configOpt.read"> Users + routerLink="/ceph-users">Ceph Users
  • - Monitoring + Alerts {{ prometheusAlertService.activeCriticalAlerts }}