From 32b3abacae4b0764ad455e6beafeb46e1cb9ce37 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Rados=C5=82aw=20Zarzy=C5=84ski?= Date: Tue, 13 Jun 2023 12:54:26 +0200 Subject: [PATCH] osd: drop the unused ECTransaction::requires_overwrite() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Radosław Zarzyński --- src/osd/ECTransaction.cc | 13 ------------- src/osd/ECTransaction.h | 4 ---- 2 files changed, 17 deletions(-) diff --git a/src/osd/ECTransaction.cc b/src/osd/ECTransaction.cc index 44876b3a89fa2..f74e6c74ade32 100644 --- a/src/osd/ECTransaction.cc +++ b/src/osd/ECTransaction.cc @@ -93,19 +93,6 @@ void encode_and_write( } } -bool ECTransaction::requires_overwrite( - uint64_t prev_size, - const PGTransaction::ObjectOperation &op) { - // special handling for truncates to 0 - if (op.truncate && op.truncate->first == 0) - return false; - return op.is_none() && - ((!op.buffer_updates.empty() && - (op.buffer_updates.begin().get_off() < prev_size)) || - (op.truncate && - (op.truncate->first < prev_size))); -} - void ECTransaction::generate_transactions( WritePlan &plan, ErasureCodeInterfaceRef &ecimpl, diff --git a/src/osd/ECTransaction.h b/src/osd/ECTransaction.h index 5cb16261a7d4b..d889dfbc248a1 100644 --- a/src/osd/ECTransaction.h +++ b/src/osd/ECTransaction.h @@ -32,10 +32,6 @@ namespace ECTransaction { std::map hash_infos; }; - bool requires_overwrite( - uint64_t prev_size, - const PGTransaction::ObjectOperation &op); - template WritePlan get_write_plan( const ECUtil::stripe_info_t &sinfo, -- 2.39.5