From 3312c32e2c6d473cef16581807d6e8efb5b41eb1 Mon Sep 17 00:00:00 2001 From: "Darrick J. Wong" Date: Tue, 27 Aug 2019 08:08:50 -0700 Subject: [PATCH] generic: test for failure to unlock inode after chgrp fails with EDQUOT This is a regression test that checks for xfs drivers that fail to unlock the inode after changing the group id fails with EDQUOT. It pairs with "xfs: fix missing ILOCK unlock when xfs_setattr_nonsize fails due to EDQUOT". Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Eryu Guan --- tests/generic/566 | 58 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/566.out | 2 ++ tests/generic/group | 1 + 3 files changed, 61 insertions(+) create mode 100755 tests/generic/566 create mode 100644 tests/generic/566.out diff --git a/tests/generic/566 b/tests/generic/566 new file mode 100755 index 00000000..e8491e54 --- /dev/null +++ b/tests/generic/566 @@ -0,0 +1,58 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0+ +# Copyright (c) 2019, Oracle and/or its affiliates. All Rights Reserved. +# +# FS QA Test No. 566 +# +# Regression test for chgrp returning to userspace with ILOCK held after a hard +# quota error. This causes the filesystem to hang if kernel is not patched. +# +# This test goes with commit 1fb254aa983bf ("xfs: fix missing ILOCK unlock when +# xfs_setattr_nonsize fails due to EDQUOT") + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/quota +. ./common/filter + +# real QA test starts here +_supported_os Linux +_supported_fs generic +_require_scratch +_require_quota +_require_user + +rm -f $seqres.full + +_qmount_option "grpquota" +_scratch_mkfs > $seqres.full +_qmount + +dir="$SCRATCH_MNT/dummy" +mkdir -p $dir +chown $qa_user $dir +$XFS_QUOTA_PROG -x -f -c "limit -g bsoft=100k bhard=100k $qa_user" $SCRATCH_MNT + +$XFS_IO_PROG -f -c 'pwrite -S 0x58 0 1m' $dir/foo >> $seqres.full +chown $qa_user "${dir}/foo" +_user_do "chgrp $qa_user ${dir}/foo" 2>&1 | _filter_scratch +ls -la ${dir} >> $seqres.full +$XFS_QUOTA_PROG -x -f -c 'report -hag' $SCRATCH_MNT >> $seqres.full + +# success, all done +status=0 +exit diff --git a/tests/generic/566.out b/tests/generic/566.out new file mode 100644 index 00000000..0005e894 --- /dev/null +++ b/tests/generic/566.out @@ -0,0 +1,2 @@ +QA output created by 566 +chgrp: changing group of 'SCRATCH_MNT/dummy/foo': Disk quota exceeded diff --git a/tests/generic/group b/tests/generic/group index 2e4a6f79..d26c080f 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -568,3 +568,4 @@ 563 auto quick 564 auto quick copy_range 565 auto quick copy_range +566 auto quick quota metadata -- 2.39.5